search

VSCodeVim / Vim

:star: Vim for Visual Studio Code
http://aka.ms/vscodevim
MIT License
13.9k stars 1.32k forks source link

Viewport position is not restored after a search is canceled or not found #4577

Closed J-Fields closed 4 years ago

J-Fields commented 4 years ago
  1. incsearch should be enabled
  2. gg in a long file
  3. L to go to the bottom of the viewport
  4. Type a search for a term only present at the bottom of the document (don't press enter)
  5. Cancel the search with <Esc> (or keep typing such that nothing is found)
  6. Notice the viewport's position is not the same as after step 3
J-Fields commented 4 years ago

This was fixed for a canceled search, but not a search not found

rishadomar commented 4 years ago

Just confirming if this is the same issue I'm experiencing:

1) Search for a text that is not found 2) Message displayed: E486: Pattern not found: 3) Pressing slash again SHOULD have taken me back to search again but instead the key is ignored.

By the way: great job with the showing of which string was not found! Previously, it didn't show which string it was so a typo in the string was difficult to spot.

J-Fields commented 4 years ago

@rishadomar No, that's a separate problem - would you mind filing an issue?