Remove or make optional regexes with lookbehinds

VSCodeVim / Vim

:star: Vim for Visual Studio Code

http://aka.ms/vscodevim

MIT License

13.99k stars 1.32k forks source link

Remove or make optional regexes with lookbehinds #5072

Open J-Fields opened 4 years ago

J-Fields commented 4 years ago

These make the extension crash when running in some browsers:

private static readonly notEscapedSlashRegex = /(?<=[^\\])\//g;
private static readonly notEscapedQuestionMarkRegex = /(?<=[^\\])\?/g;

const regex = /(?<=^(?:~|\$HOME)).*/;

nalbury commented 3 years ago

Just ran into this myself trying to the extension with GitHub codespaces in safari. Was curious if there was any progress here, and if not, if you were open to contributions?

Thanks!

J-Fields commented 3 years ago

@nalbury Definitely open to contributions!

mustafahemida commented 3 years ago

I try to fallow the apps but it's not working with the Cod what should I do !

jsjoeio commented 3 years ago

I did some testing in Safari + Codespaces and confirm that issue happens with versions newer than v1.20.3

Video

This is of v1.20.3 working as expected.

https://user-images.githubusercontent.com/3806031/122597005-965a5c80-d01f-11eb-807e-377e4cd883ea.mov

@J-Fields how difficult would this be to fix? Wondering if you could post some guidance for anyone who might be interested in contributing (for their first time).