Undo broken with new VS Code

[marchbox]

Type: Bug

I just upgraded to VS Code 1.74.0 today, and started noticing an issue with undo command ("u") in Vim. It appears to only go back 2-3 iterations (my current Vim: History setting is "50"). And if I hit CTRL+Z, it first undoes what "u" just undid, then start actually undoing, e.g.

• i → insert mode
• a → "a"
• b → "ab"
• ESC → normal mode
• u → "a"
• u → nothing happens, but should've undone "a"
• CTRL-Z → "ab" (undoes what u just undid)
• CTRL-Z → "a"
• CTRL-Z → ""

Here is my VS Code info: Version: 1.74.0 (Universal) Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91 Date: 2022-12-05T16:43:37.594Z (2 days ago) Electron: 19.1.8 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: No

Extension version: 1.24.3 VS Code version: Code 1.74.0 (Universal) (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:43:37.594Z) OS version: Darwin arm64 21.6.0 Modes: Sandboxed: No

System Info

|Item|Value| |---|---| |CPUs|Apple M1 Max (10 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|2, 2, 2| |Memory (System)|64.00GB (32.10GB free)| |Process Argv|--crash-reporter-id 934e8b32-9713-4d8f-957f-354420e03177| |Screen Reader|yes| |VM|0%|

A/B Experiments

``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vsdfh931:30280409 vshan820:30294714 vstes263cf:30335440 vscoreces:30445986 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 azure-dev_surveyone:30548225 pyindex848:30577860 nodejswelcome1:30587005 2e4cg342:30602488 gswce1:30612156 iaj6b796:30613358 dbltrim-noruby:30604474 89544117:30613380 fim-prod:30623723 ejf25101:30620729 ```

[J-Fields]

Apologies for my slowness in responding to this issue; I've been quite busy with other things recently.

This should be fixed in v1.25.1. If you're still experiencing this issue, please leave a comment letting me know. If there's some other misbehavior related to undo, please file a new ticket.

[huyz]

@J-Fields thank you for letting me unsubscribe from this embarrassing whine-fest 😜

[alecthomas]

Thanks @J-Fields, I really appreciate the effort that you've put into this extension, it's amazing.

[iddm]

Apologies for my slowness in responding to this issue; I've been quite busy with other things recently.

This should be fixed in v1.25.1. If you're still experiencing this issue, please leave a comment letting me know. If there's some other misbehavior related to undo, please file a new ticket.

Thank you, but I can't see it in the extensions repository of vscode. Have you published it?

[skplunkerin]

Thank you, but I can't see it in the extensions repository of vscode. Have you published it?

There's been 2 new versions released recently, I can see both of them in VSCode so they have been released (checkout the version history on the VSCodeVim extension page here).

In VSCode you can also check the versions by right clicking on the extension -> click Install Another Version and see the available versions; if you don't see them you might need to make sure VSCode is updated or maybe restart it? Or connect to the internet? 😄 🤷

[iddm]

Thank you, but I can't see it in the extensions repository of vscode. Have you published it?

There's been 2 new versions released recently, I can see both of them in VSCode so they have been released (checkout the version history on the VSCodeVim extension page here).

In VSCode you can also check the versions by right clicking on the extension -> click Install Another Version and see the available versions; if you don't see them you might need to make sure VSCode is updated or maybe restart it? Or connect to the internet? smile shrug

I have already done everything you suggested except for first upgrading to the latest vscode and then checking, perhaps, this is the reason I couldn't see the new version. :-)

[t-var-s]

Thank you for the fix 👍

[marchbox]

Thank you for fixing this!

[hawkiboy]

Still broken for me in version 1.26.0