VSCodeVim / Vim

:star: Vim for Visual Studio Code
http://aka.ms/vscodevim
MIT License
13.57k stars 1.3k forks source link

fixes #9006 easymotionDimColor has no effect #9059

Closed HenryTSZ closed 3 weeks ago

HenryTSZ commented 1 month ago

What this PR does / why we need it:

fixes #9006 easymotionDimColor has no effect

Which issue(s) this PR fixes

9006

Special notes for your reviewer:

This static property is initialized immediately when the class is loaded (due to the nature of static properties in TypeScript/JavaScript), not when an instance of the class is created. it only depends on the file containing the class (easymotion.ts) being processed by the JavaScript runtime.

https://github.com/VSCodeVim/Vim/blob/0e1e48797c5205df914f79a08b6e773be3c6feb0/src/actions/plugins/easymotion/easymotion.ts#L26-L28

So, when we used import, this value is initialized

https://github.com/VSCodeVim/Vim/blob/0e1e48797c5205df914f79a08b6e773be3c6feb0/src/mode/modeHandler.ts#L8

But at this time, the configuration.asymotionDimColor has not been loaded yet

https://github.com/VSCodeVim/Vim/blob/0e1e48797c5205df914f79a08b6e773be3c6feb0/extensionBase.ts#L101-L102