Closed ljones140 closed 3 months ago
Downgrading to VSCode 1.89.1 and split panes works
I didn't realize my VSCode updated and thought I was going crazy when <C-w> + v
wasn't working. Hopefully we can get a quick resolution for this
Seems like this is due to some changes made for the new "Tab Multi Select" feature
I noticed that resourceOrContext
and commandContext
were undefined
when the action was run via Command Palette > Split Editor
. When run via VSCodeVim
, they were both empty objects.
Setting workbench.action.splitEditor
and workbench.action.splitEditorOrthogonal
action arguments to undefined
seems to fix the immediate issue. But, I don't know enough about the architecture of VSCodeVim nor VSCode to say if this is the correct solution.
https://github.com/VSCodeVim/Vim/assets/46084870/12f4294f-b23f-42a5-9797-7cf1313b3cff
I'm having similar issues
<C-w> + v
- vertical split
and
<C-w> + s
- horizontal split
Are no longer working for me after updating to 1.90.0
of visual studio code
Same here - broken since 1.90.0
Same here
I'm having similar issues
<C-w> + v
- vertical splitand
<C-w> + s
- horizontal splitAre no longer working for me after updating to
1.90.0
of visual studio code
I'll edit the issue to add these thanks
This wasn't broken on insiders until the latest update. Now broken on 1.91.0-insider - same behaviour
At least for vertical/horizontal splits one can one can add the following shortcuts to keybinding.json
as a temporary workaround, I guess:
{
"key": "ctrl+w v",
"command": "workbench.action.splitEditor"
},
{
"key": "ctrl+w s",
"command": "workbench.action.splitEditorDown"
},
Another possible workaround is to modify vim extension settings:
{
...
"vim.normalModeKeyBindings": [
{
"before": ["C-w", "v"],
"after": [":", "v", "s", "<Enter>"],
},
{
"before": ["C-w", "s"],
"after": [":", "s", "p", "<Enter>"],
},
...
}
I like it better than modifying keybinding.json
because it doesn't break Ctrl+W behaviour in insert mode.
Adding same behavior for menu options
Same Here
Another possible workaround is to modify vim extension settings:
{ ... "vim.normalModeKeyBindings": [ { "before": ["C-w", "v"], "after": [":", "v", "s", "<Enter>"], }, { "before": ["C-w", "s"], "after": [":", "s", "p", "<Enter>"], }, ... }
I like it better than modifying
keybinding.json
because it doesn't break Ctrl+W behaviour in insert mode.
This workaround works in stable / 1.19.0
but not in insiders version 1.91.0-insider
, so there's probably more changes ahead that will break it again.
At least for vertical/horizontal splits one can one can add the following shortcuts to
keybinding.json
as a temporary workaround, I guess:{ "key": "ctrl+w v", "command": "workbench.action.splitEditor" }, { "key": "ctrl+w s", "command": "workbench.action.splitEditorDown" },
here's that but for config json
"vim.normalModeKeyBindings": [
{
"before": [
"<C-w>",
"v"
],
"commands": [
"workbench.action.splitEditor"
]
},
{
"before": [
"<C-w>",
"s"
],
"commands": [
"workbench.action.splitEditorDown"
]
},
]
At least for vertical/horizontal splits one can one can add the following shortcuts to
keybinding.json
as a temporary workaround, I guess:{ "key": "ctrl+w v", "command": "workbench.action.splitEditor" }, { "key": "ctrl+w s", "command": "workbench.action.splitEditorDown" },
here's that but for config json
"vim.normalModeKeyBindings": [ { "before": [ "<C-w>", "v" ], "commands": [ "workbench.action.splitEditor" ] }, { "before": [ "<C-w>", "s" ], "commands": [ "workbench.action.splitEditorDown" ] }, ]
👍 Cool, add this configuration code snippet to setting.json to bypass the above issue.
For anyone interested, I was able to additionally add the following config to allow me to regain my keyboard navigation, which also broke when I updated.
{
"key": "ctrl+w k",
"command": "workbench.action.navigateUp"
},
{
"key": "ctrl+w j",
"command": "workbench.action.navigateDown"
},
{
"key": "ctrl+w h",
"command": "workbench.action.navigateLeft"
},
{
"key": "ctrl+w l",
"command": "workbench.action.navigateRight"
},
In my case, I'm used to using <C-k>
, <C-l>
, <C-j>
, <C-h
.
Same here.
Also I think ctrl+w o
(show current panel and close others) and ctrl+w q
(close current panel) are also broken.
Same here
Same problem
when will this fix?
same
Same here
Still have the problem in 1.90.2 on macOS
same
how can we push this to fix as soon as possible?
Same problem here! Would be great to have this fixed instead of having to use a workaround. Wish I could do this myself, but I haven't got the time to dive into a new open source project atm.
Would be nice to have a release for this fix.
@J-Fields Can this fix be released? I still need to keep resetting VSCode to an older version. Thank you!
Describe the bug
Using + s` for new panes are no longer working when on latest version of VSCode 1.90
https://code.visualstudio.com/updates/v1_90
<C-w> + v
anTo Reproduce Steps to reproduce the behavior:
<C-w>
followed byv
or<C-w>
followed bys
Expected behavior New pane opens
Environment (please complete the following information):