search

VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.44k stars 1.1k forks source link

Add-on badges don't work #125

Closed JPabloLassala closed 5 years ago

JPabloLassala commented 5 years ago

Here are the badges on VSCodium image

While here are the same badges on VSCode image

(I call it badges because the VSCode site uses that name) It's just a detail, but I found nothing after a search so I thought it doesn't hurt to list it.

ealap commented 5 years ago

I have the same issue. I think this has something to do VSCode's restriction on viewing SVG in markdown files.

Golotvinov commented 5 years ago

Same problem here.

VSCodium version: 1.33

Screenshot_1

Seems to be the case in every extension that uses the shields.

stripedpajamas commented 5 years ago

I found the problem -- MS only renders badges from "allowed" domains. The allowed domains list is specified in the product.json file, but we are not currently populating that field. When I add the below to my local product.json file, the badges render properly. We will need to update build.sh to add this field to product.json pre-build.

"extensionAllowedBadgeProviders": ["api.bintray.com", "api.travis-ci.com", "api.travis-ci.org", "app.fossa.io", "badge.fury.io", "badge.waffle.io", "badgen.net", "badges.frapsoft.com", "badges.gitter.im", "badges.greenkeeper.io", "cdn.travis-ci.com", "cdn.travis-ci.org", "ci.appveyor.com", "circleci.com", "cla.opensource.microsoft.com", "codacy.com", "codeclimate.com", "codecov.io", "coveralls.io", "david-dm.org", "deepscan.io", "dev.azure.com", "flat.badgen.net", "gemnasium.com", "githost.io", "gitlab.com", "godoc.org", "goreportcard.com", "img.shields.io", "isitmaintained.com", "marketplace.visualstudio.com", "nodesecurity.io", "opencollective.com", "snyk.io", "travis-ci.com", "travis-ci.org", "visualstudio.com", "vsmarketplacebadge.apphb.com", "www.bithound.io", "www.versioneye.com"]