VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
24.64k stars 1.04k forks source link

VSCodium wayland #1593

Closed RosGtHub closed 4 months ago

RosGtHub commented 1 year ago

Describe the bug When i maximize the application it doesn't fully cover the screen Screenshots Screenshot from 2023-08-06 03-25-20

Desktop (please complete the following information): [System] OS: Arch Linux rolling n/a Arch: x86_64 Kernel: 6.4.7-arch1-3 Desktop: GNOME Display Server: wayland Sandboxed: no App Manager: aur

[CPU] Vendor: AuthenticAMD Model: AMD Ryzen 5 5600G with Radeon Graphics Physical cores: 6 Logical cores: 12

[Memory] RAM: 15.4 GB Swap: 4.0 GB

[Graphics] Vendor: AMD OpenGL Renderer: AMD Radeon RX 6700 XT (navi22, LLVM 15.0.7, DRM 3.52, 6.4.7-arch1-3) OpenGL Version: 4.6 (Compatibility Profile) Mesa 23.1.4 OpenGL Core: 4.6 (Core Profile) Mesa 23.1.4 OpenGL ES: OpenGL ES 3.2 Mesa 23.1.4 Vulkan Version: 1.3.255 Vulkan Drivers: AMD Radeon RX 6700 XT (RADV NAVI22) (1.3.246)

Lime-Parallelogram commented 1 year ago

I think I might be having a related issue. I'm using the Flatpak version (I know its not officially supported so I'm reluctant to open a separate issue here) but in the latest release (released on 4th August on Flathub) my window decorations have disappeared. You cannot resize or move the window with the mouse.

I'm using Fedora 38 with a Gnome 44.3. Have rolled back to the previous version and everything is working perfectly.

Screenshot from 2023-08-06 10-26-41

noonsleeper commented 1 year ago

@Lime-Parallelogram hey don't hesitate and open an issue in https://github.com/flathub/com.vscodium.codium/issues for the flatpak =)

Fxsch commented 11 months ago

An issue was opened there but they just gave a workaround (running it through the terminal and adding --enable-features=WaylandWindowDecorations) and closed it. The issue wasn't actually fixed. But since that workaround is an argument given to VSCodium itself, it might have to be fixed here.

wanesty commented 10 months ago

arch kde wayland, vscodium-bin-marketplace from the aur:

crashed when maximizing the wayland window, issue is not present with the xwayland .desktop

running it through the terminal and adding --enable-features=WaylandWindowDecorations

does fix the wayland .desktop !


said .desktop files for reference:

codium.desktop ```properties [Desktop Entry] Name=VSCodium Comment=Code Editing. Redefined. GenericName=Text Editor Exec=/usr/bin/codium --unity-launch %F Icon=vscodium Type=Application StartupNotify=false StartupWMClass=VSCodium Categories=Utility;Development;IDE; MimeType=text/plain;inode/directory; Actions=new-empty-window; Keywords=vscode; [Desktop Action new-empty-window] Name=New Empty Window Exec=/usr/bin/codium --new-window %F Icon=vscodium ```
codium-wayland.desktop ```properties [Desktop Entry] Name=VSCodium - Wayland Comment=Code Editing. Redefined. GenericName=Text Editor Exec=/usr/bin/codium --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland --unity-launch %F Icon=vscodium Type=Application StartupNotify=false StartupWMClass=codium-url-handler Categories=Utility;Development;IDE; MimeType=text/plain;inode/directory; Actions=new-empty-window; Keywords=vscode; [Desktop Action new-empty-window] Name=New Empty Window Exec=/usr/bin/codium --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland --new-window %F Icon=vscodium ``` - ~~so adding `--enable-features=WaylandWindowDecorations` as an argument to the exec line does fix it.~~

edit cause i'm a dumbass: the codium-wayland.desktop already includes said argument, and starting codium with codium --enable-features=WaylandWindowDecorations (what i did initialy and thought it worked) defaults to x11(know thanks to xprop) so no this argument doesn't fix my issue.

edit2: https://github.com/microsoft/vscode/issues/184124

noonsleeper commented 9 months ago

@wanesty you need these two parameters only

codium --enable-features=WaylandWindowDecorations --ozone-platform-hint=auto

Force platform (--ozone-platform=wayland) doesn't work well, I mean platform autodetection either works well, but at least is more stable.

wanesty commented 9 months ago

Force platform (--ozone-platform=wayland) doesn't work well, I mean platform autodetection either works well, but at least is more stable.

does make it use wayland but it's not fixing the crashes on fullscreen :/ ty tho :heart: :3

daiyam commented 9 months ago

Feel free to make any PR to facilitate the integration of Wayland!

noonsleeper commented 6 months ago

does make it use wayland but it's not fixing the crashes on fullscreen :/ ty tho ❤️ :3

Are you using an nvidia card? If is that the case, the latest version of flatpak disable gpu accel for nvidia under wayland. Can you try that?

wanesty commented 6 months ago

Are you using an nvidia card?

nope, amd RX6700 with mesa drivers, it's now fixed for me when reproducing the thing that was causing issue (fullscreen on some files with nu highlighter with wayland).

RosGtHub commented 4 months ago

It was fixed!

WECLEYArtz commented 4 months ago

It was fixed!

well not for me. image

Debian 12 Plasma 5.27.5