VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
24.64k stars 1.04k forks source link

Crash reporter enabled via CLI options? #1677

Open Philzen opened 10 months ago

Philzen commented 10 months ago

Describe the bug When looking at my process list, it transpires there are explicit flags set to enable the crash-reporter, which otherwise should be clearly disabled from looking at the argv.json in my config directory.

Please confirm that this problem is VSCodium-specific

I don't have MS VSCode installed, so i cannot test that. This issue is purely to check why these CLI options are the case here.

Please confirm that the issue/resolution isn't already documented

To Reproduce Steps to reproduce the behavior:

  1. Use either VSCodium in Desktop manager, or use codium or vscodium commands to start up vscodium
  2. Check your processes:
user       60902  4.2  1.8 34105852 145240 ?     Sl   15:56   0:14 /opt/vscodium-bin/codium --type=gpu-process --enable-crash-reporter=bfa0e9a1-98c7-4fad-a790-3fd6aa9a0290,no_channel --user-data-dir=/home/user/.config/Code --gpu-preferences=WAAAAAAAAAAgAAAEAAAAAAAAAAAAAAAAAABgAAAAAAA4AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAGAAAAAAAAAAYAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAA== --shared-files --field-trial-handle=0,i,17338561364270937052,979004060025186129,262144 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess
user       60909  0.0  0.9 33884244 72804 ?      Sl   15:56   0:00 /opt/vscodium-bin/codium --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --enable-crash-reporter=bfa0e9a1-98c7-4fad-a790-3fd6aa9a0290,no_channel --user-data-dir=/home/user/.config/Code --standard-schemes=vscode-webview,vscode-file --enable-sandbox --secure-schemes=vscode-webview,vscode-file --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --streaming-schemes --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,17338561364270937052,979004060025186129,262144 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess
user       60932 14.6  2.5 1185832116 204528 ?   Sl   15:56   0:49 /opt/vscodium-bin/codium --type=renderer --enable-crash-reporter=bfa0e9a1-98c7-4fad-a790-3fd6aa9a0290,no_channel --user-data-dir=/home/user/.config/Code --standard-schemes=vscode-webview,vscode-file --enable-sandbox --secure-schemes=vscode-webview,vscode-file --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --streaming-schemes --app-path=/opt/vscodium-bin/resources/app --enable-sandbox --enable-blink-features=HighlightAPI --first-renderer-process --lang=en-US --num-raster-threads=2 --enable-main-frame-before-activation --renderer-client-id=4 --time-ticks-at-unix-epoch=-1696558374994156 --launch-time-ticks=42189808694 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,17338561364270937052,979004060025186129,262144 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess --vscode-window-config=vscode:3806d7d1-ca6e-4269-b8f2-4c93857cb8df
user       60960  4.0  1.5 1177412972 121584 ?   Sl   15:56   0:13 /opt/vscodium-bin/codium --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --enable-crash-reporter=bfa0e9a1-98c7-4fad-a790-3fd6aa9a0290,no_channel --user-data-dir=/home/user/.config/Code --standard-schemes=vscode-webview,vscode-file --enable-sandbox --secure-schemes=vscode-webview,vscode-file --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --streaming-schemes --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,17338561364270937052,979004060025186129,262144 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess
user       61391  0.8  1.3 1177415476 104864 ?   Sl   15:58   0:01 /opt/vscodium-bin/codium --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --dns-result-order=ipv4first --inspect-port=0 --enable-crash-reporter=bfa0e9a1-98c7-4fad-a790-3fd6aa9a0290,no_channel --user-data-dir=/home/user/.config/Code --standard-schemes=vscode-webview,vscode-file --enable-sandbox --secure-schemes=vscode-webview,vscode-file --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --streaming-schemes --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,17338561364270937052,979004060025186129,262144 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess
user       61411  0.3  1.0 1177415472 84960 ?    Sl   15:58   0:00 /opt/vscodium-bin/codium --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --enable-crash-reporter=bfa0e9a1-98c7-4fad-a790-3fd6aa9a0290,no_channel --user-data-dir=/home/user/.config/Code --standard-schemes=vscode-webview,vscode-file --enable-sandbox --secure-schemes=vscode-webview,vscode-file --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --streaming-schemes --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,17338561364270937052,979004060025186129,262144 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess
user       61919  0.0  0.0   6912  2652 pts/9    S+   16:01   0:00 grep --colour=auto -e codium.*--enable-crash-reporter

Expected behavior

None of these processes should have the --enable-crash-reporter flag.

Sidenote: the UUID shown in the flag is not the same as i see in argv.json.

Desktop (please complete the following information):

Additional context I disabled all extensions to make sure they are not causing that. Also i've checked the scripts in /usr/bin/codium and /usr/bin/vscodium and printenv but i was unable to identify the source of these CLI options.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!

Philzen commented 4 months ago

Bump.

wtechgo commented 5 days ago

In settings, is set Telemetry to off.
However, in the processes, I still see cli args --enable-crash-reporter.
It looks like crash reporter is still enabled, wtf.

/opt/vscodium-bin/codium
 \_ /opt/vscodium-bin/codium --type=zygote --no-zygote-sandbox
 |   \_ /opt/vscodium-bin/codium --type=gpu-process --enable-crash-reporter=a66bxxxx-xxxx-xxx-xxxx-xxxxc6210,no_channel ...
 \_ /opt/vscodium-bin/codium --type=zygote
 |   \_ /opt/vscodium-bin/codium --type=zygote
 |       \_ /opt/vscodium-bin/codium --type=renderer --enable-crash-reporter=a66bxxxx-xxxx-xxx-xxxx-xxxxc6210,no_channel ...
 \_ /opt/vscodium-bin/codium --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --enable-crash-reporter=a66bxxxx-xxxx-xxx-xxxx-xxxxc6210,no_channel ...
 \_ /opt/vscodium-bin/codium --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --enable-crash-reporter=a66bxxxx-xxxx-xxx-xxxx-xxxxc6210,no_channel ...
 \_ /opt/vscodium-bin/codium --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --dns-result-order=ipv4first --inspect-port=0 --enable-crash-reporter=a66bxxxx-xxxx-xxx-xxxx-xxxxc6210,no_channel ...
 \_ /opt/vscodium-bin/codium --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --enable-crash-reporter=a66bxxxx-xxxx-xxx-xxxx-xxxxc6210,no_channel ...