VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.67k stars 1.12k forks source link

Sign Windows Binaries (False positive Malware) #174

Open Makazzz opened 5 years ago

Makazzz commented 5 years ago

Each time I open VSCodium ia32 in portable mode on a Windows 10 x64 with Bitdefender; It's saying Atc4.detection or Malware detected and block it.

-[✓] This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

-[✓] I checked the Docs page and my issue is not mentioned there.

To Reproduce Steps to reproduce the behavior:

  1. Go to the root folder of the app
  2. Open VSCodium.exe ia32 version
  3. Wait to see the warning with Bitdefender stop the app and block it

falsepositive

JL2210 commented 5 years ago

Probably because this tries to upload telemetry to 0.0.0.0 and the Microsoft URLs are allowed in the anti-malware software.

Makazzz commented 5 years ago

Probably because this tries to upload telemetry to 0.0.0.0 and the Microsoft URLs are allowed in the anti-malware software.

But why it is doing that only in the ia32 version? I have no problem with the x64. My settings.json is this : { "telemetry.enableTelemetry": false, "telemetry.enableCrashReporter": false, "update.channel": "none", "update.mode": "manual", "update.enableWindowsBackgroundUpdates": false, "update.showReleaseNotes": false, "workbench.enableExperiments": false, "workbench.settings.enableNaturalLanguageSearch": false, "extensions.autoUpdate": false, "git.ignoreMissingGitWarning": true, }

JL2210 commented 5 years ago

Microsoft force enables telemetry anyway. I'd blame it on Windows.

stripedpajamas commented 5 years ago

Pretty weird situation @Makazzz -- I will try to reproduce it on my Windows machine and figure out what exactly it is reacting to. Thanks for reporting!!

knopp commented 5 years ago

Is the windows binary codesigned? Distribution windows binaries without (preferably EV certificate) is world of hurt, as everything flaggs it as malware. And even with certificate there are still often heaps of false positives.

stripedpajamas commented 5 years ago

The Windows binary is not being codesigned at this time. I should prioritize that if it would help with malware false positives.

Makazzz commented 5 years ago

Information: I can't test this problem anymore because I uninstalled Bitdefender.

GitMensch commented 4 years ago

@stripedpajamas wrote:

The Windows binary is not being codesigned at this time. I should prioritize that if it would help with malware false positives.

It definitely would. Ideally both the executable and the installer exe+msi would use the same code sign

GitMensch commented 3 years ago

Just adding the reference: #527 (already closed, but found first in my search).

GitMensch commented 2 years ago

@daiyam Closed, so the installer and executables are now signed?

daiyam commented 2 years ago

no, I've closed it because of "False positive Malware"

GitMensch commented 2 years ago

Then the "old issue of signing the codium executable and the installer (however this may work) is still open, I'd suggest to keep track of code signing certificate issues here.

GitMensch commented 1 year ago

reopening it to keep track of code-signing here.