VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
24.31k stars 1.02k forks source link

version 1.85.1.23348 & 1.85.0.23343 Does Not install, linked to GLibC 2.29 #1760

Closed fred410 closed 4 months ago

fred410 commented 6 months ago

That pretty much it...

the version 1.85.0.23343 does not install, linked to GLibC 2.29 where the previous version 1.84.2.23319 links to GLibC 2.17

This is the: "codium-1.85.0.23343-el7.x86_64.rpm" package.

dsommers commented 6 months ago

I'm having the same issue on RHEL-8.9.

@daiyam @stripedpajamas ... I'm willing to help out publish this package via a Fedora Copr repository if we can get the src.rpm files from somewhere (not the .tar.gz; unless it contains the codium.spec file).

daiyam commented 6 months ago

The issue is due to https://github.com/VSCodium/vscodium/issues/1756#issuecomment-1848943684

@dsommers Feel free to make a PR to generate the src.rpm. You can check the doc https://github.com/VSCodium/vscodium/blob/master/docs/howto-build.md Then we can publish it in the release.

dsommers commented 6 months ago

@daiyam How do you make the RPM packages today? I tried poking around a bit, but I might be barking up the wrong tre^H^H^H repos ...

dsommers commented 6 months ago

Never mind .... I think I understand how ....

$ cat prepare_assets.sh
  if [[ "${SHOULD_BUILD_RPM}" != "no" ]]; then
    yarn gulp "vscode-linux-${VSCODE_ARCH}-build-rpm"
  fi
daiyam commented 6 months ago

or ./build/build.sh -p (I need to add the flags in the doc...)

dsommers commented 6 months ago

Thx! I need to do some digging into the build issues here ...

yarn install v1.22.19
$ node build/npm/preinstall.js
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "@microsoft/1ds-core-js > @microsoft/applicationinsights-core-js@2.8.15" has unmet peer dependency "tslib@*".
warning " > gulp-postcss@9.0.0" has unmet peer dependency "postcss@^8.0.0".
warning " > tsec@0.2.7" has unmet peer dependency "@bazel/bazelisk@>=1.7.5".
warning " > tsec@0.2.7" has unmet peer dependency "@bazel/concatjs@>=5.3.0".
[4/4] Building fresh packages...
error [...]/vscodium/vscode/node_modules/@parcel/watcher: Command failed.
Exit code: 1
Command: node-gyp-build
Arguments: 
Directory: [...]/vscodium/vscode/node_modules/@parcel/watcher
Output:
node:events:495
      throw er; // Unhandled 'error' event
      ^

Error: spawn node-gyp ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:284:19)
    at onErrorNT (node:internal/child_process:477:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:290:12)
    at onErrorNT (node:internal/child_process:477:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn node-gyp',
  path: 'node-gyp',
  spawnargs: [ 'rebuild' ]
}
daiyam commented 6 months ago

try with python 3.11 (due to https://github.com/nodejs/node-gyp/issues/2869)

fred410 commented 6 months ago

Same issue as before -- version [1.85.1.23348] links to GLibC 2.29. If an OLDER GLibC will NOT be Support -- especially that of package "codium-1.85.0.23348-el7.x86_64.rpm" or "codium-1.85.0.23343-el7.x8664.rpm" -- Which is Centos7 or Oracle 7 (or the like) ... Then REMOVE the "el7" branch from the releases -- "el7" GLibC is natively 2.17. (on a side note: if you can build codium at the GLibC 2.28 level - that would work - that I built and pushed out)_

fred410 commented 6 months ago

FYI Addendum: the actual MS product (latest, same versions as here) links against GLibC 2.17. SO something in the build processing has changed that and links to GLibC 2.29

daiyam commented 6 months ago

SO something in the build processing has changed that and links to GLibC 2.29

Yep, the use of Node-v18 in the build process on linux (was already the case on other platforms)

daiyam commented 5 months ago

Visual Studio Code v1.86.0 has moved to el8

daiyam commented 4 months ago

VSCodium 1.86.2.24053 should fix the issue.

dsommers commented 4 months ago

Confirmed. Just installed the update from the yum/dnf repo on RHEL 8.9. That seems to work as expected.

(I'm sorry I haven't had time to dig into the Copr builds properly yet; it's not forgotten - just too much at work to have spare cycles for this)