Releases 1.89.0.24127 doesn't contains Mac OS binary

sendaoYan commented 1 month ago

Describe the bug Releases 1.89.0.24127 doesn't contains macos binary

Please confirm that this problem is VSCodium-specific

[x] This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

Please confirm that the issue/resolution isn't already documented

[x] I checked the Docs page and the Troubleshooting page and my issue is not mentioned there.

To Reproduce Steps to reproduce the behavior:

Go to Releases 1.89.0.24127 web
search dmg

Expected behavior 1.88.1.24104 has contains dmg binary:

Screenshots

Desktop (please complete the following information):

OS: [e.g. Mac OS, Ubuntu 20.04, etc] MacOS
Architecture [e.g. x64, ia32, arm64] aarch64
Version [e.g. 1.33.0] Releases 1.89.0.24127
App Manager [e.g. Winget, Homebrew, Snap, AUR, RPM, Nix, ...] dmg
Sandboxed [e.g. no, Flatpak, Snap] no

wanderingmeow commented 1 month ago

During the build process, an error occurred due to an expired codesign certificate (CSSMERR_TP_CERT_EXPIRED). The build logs can be found here: https://github.com/VSCodium/vscodium/actions/runs/8962504270/job/24611461953#step:9:38.

It appears that the developer certificate from @stripedpajamas to sign the software has expired, or there is something wrong with the CI configuration, but I've checked and it doesn't seem to have changed recently.

Reference: https://forums.developer.apple.com/forums/thread/712043

daiyam commented 1 month ago

Yep, I've been pondering what to do since Sunday... (logs added in the Insiders version). But I thinking I've already seen the CSSMERR_TP_CERT_EXPIRED error but I can't be sure.

Renew the certificate / Get an official from Apple. What happens when the certificate change? Broken update?

wanderingmeow commented 1 month ago

I tried compiling with an ad-hoc certificate (self-generated) using CI: https://github.com/wanderingmeow/vscodium/commit/0a0a9c8a165198d7c0fbd76141f4b3ade6a865b1, and ran the action.

So far, it seems to work fine, except for an initial startup issue where I'm prompted to access "VSCodium Safe Storage" in the keychain.

An issue that may affect users with full security enabled: the "Apple cannot check the app for malicious software" alert. This might occur every time the app is updated, as shown in the screenshot:

daiyam commented 1 month ago

Yep, it's a know issue. But I've decided to buy an Apple's developer account to get a valid certificate.

daiyam commented 4 weeks ago

Hi, the latest Insiders version is notarized. Can you test it? https://github.com/VSCodium/vscodium-insiders/releases/tag/1.90.0.24153-insider

By the way, you will need to manually update since the certificate has been changed (the update process fails the verification of the downloaded app).

sendaoYan commented 4 weeks ago

Hi, the latest Insiders version is notarized. Can you test it? https://github.com/VSCodium/vscodium-insiders/releases/tag/1.90.0.24153-insider

By the way, you will need to manually update since the certificate has been changed (the update process fails the verification of the downloaded app).

The new version report a faillure when install the chinese language: End of central directory record signature not found. Either not a zip file, or file is truncated.

2024-06-04 20:29:29.268 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-toolsai.datawrangler' wants API proposal 'debugFocus' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-06-04 20:29:29.280 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'github.copilot-chat' wants API proposal 'chatParticipant' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-06-04 20:29:29.280 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'apidev.azure-api-center' wants API proposal 'chatParticipant' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-06-04 20:29:29.280 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'apidev.azure-api-center' wants API proposal 'languageModels' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-06-04 20:29:29.471 [info] Started local extension host with pid 81313.
2024-06-04 20:29:29.471 [info] Started initializing default profile extensions in extensions installation folder. file:///Users/yansendao/.vscodium-insiders/extensions
2024-06-04 20:29:29.543 [info] Completed initializing default profile extensions in extensions installation folder. file:///Users/yansendao/.vscodium-insiders/extensions
2024-06-04 20:29:35.078 [info] [perf] Render performance baseline is 29ms
2024-06-04 20:29:48.876 [error] End of central directory record signature not found. Either not a zip file, or file is truncated.: Error: End of central directory record signature not found. Either not a zip file, or file is truncated.
    at S (/Applications/VSCodium - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:47:34104)
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:47:35611
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:40:7
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:190:5
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:712:5
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/fd-slicer.js:33:7
    at FSReqCallback.wrapper [as oncomplete] (node:fs:666:5)
2024-06-04 20:33:58.487 [error] Error: End of central directory record signature not found. Either not a zip file, or file is truncated.
    at S (/Applications/VSCodium - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:47:34104)
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:47:35611
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:40:7
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:190:5
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:712:5
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/fd-slicer.js:33:7
    at FSReqCallback.wrapper [as oncomplete] (node:fs:666:5)
2024-06-04 20:33:58.497 [error] End of central directory record signature not found. Either not a zip file, or file is truncated.: Error: End of central directory record signature not found. Either not a zip file, or file is truncated.
    at S (/Applications/VSCodium - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:47:34104)
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:47:35611
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:40:7
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:190:5
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:712:5
    at /Applications/VSCodium - Insiders.app/Contents/Resources/app/node_modules.asar/yauzl/fd-slicer.js:33:7
    at FSReqCallback.wrapper [as oncomplete] (node:fs:666:5)

daiyam commented 4 weeks ago

End of central directory record signature not found. Either not a zip file, or file is truncated.

Same error for any extension...

I need to check on another os since the error seems like to be about a bad zip file.

jeanp413 commented 4 weeks ago

End of central directory record signature not found. Either not a zip file, or file is truncated.

I was about to create an issue about this, it's an open-vsx bug already reported https://github.com/eclipse/openvsx/issues/922 and merged https://github.com/eclipse/openvsx/pull/928 but not deployed

@daiyam you could skip the signature verification for this release here https://github.com/gitpod-io/openvscode-server/commit/3c72b12e4414a4691f7a19cdfae262b429270ee9

daiyam commented 4 weeks ago

@daiyam you could skip the signature verification for this release here gitpod-io/openvscode-server@3c72b12

Ok, so it's a new thing for 1.90. Thanks for the update.

daiyam commented 3 weeks ago

@jeanp413 I've done the patch in https://github.com/VSCodium/vscodium/pull/1915

waja commented 3 weeks ago

Hmm ... I can't find any arm dmg at https://github.com/VSCodium/vscodium/releases/tag/1.90.0.24158

daiyam commented 3 weeks ago

Hmm ... I can't find any arm dmg at https://github.com/VSCodium/vscodium/releases/tag/1.90.0.24158

Yep. The job is failing, I'm working on it (https://github.com/VSCodium/vscodium/actions/runs/9405828286)

daiyam commented 3 weeks ago

Hmm ... I can't find any arm dmg at https://github.com/VSCodium/vscodium/releases/tag/1.90.0.24158

Yep. The job is failing, I'm working on it (https://github.com/VSCodium/vscodium/actions/runs/9405828286)

The macOS versions are available for x86 and arm

VSCodium / vscodium

Releases 1.89.0.24127 doesn't contains Mac OS binary #1868