VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
24.27k stars 1.02k forks source link

Jedi causes "Do you want to terminate the active terminal session?" on close #1873

Closed wjandrea closed 1 month ago

wjandrea commented 1 month ago

Type: Bug

Behaviour

Popup on close: "Do you want to terminate the active terminal session?"

Steps to reproduce:

  1. Set python.languageServer = Jedi (or Default if Pylance is not available)
  2. Make sure Jedi is running, for example, lint a Python script
  3. Try to exit VSC window

Diagnostic data

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

``` 2024-05-10 14:10:43.653 [info] Default formatter is set to ms-python.autopep8 for workspace /home/wja/testdir 2024-05-10 14:10:43.766 [info] Test server listening. 2024-05-10 14:10:43.820 [info] > conda info --json 2024-05-10 14:10:43.823 [info] Python interpreter path: ~/Programs/miniconda3/envs/anaconda3_11+/bin/python 2024-05-10 14:10:44.072 [info] > pyenv which python 2024-05-10 14:10:44.072 [info] cwd: . 2024-05-10 14:10:44.388 [info] Discover tests for workspace name: testdir - uri: /home/wja/testdir/tmp.py 2024-05-10 14:10:45.242 [info] > conda run -p ~/Programs/miniconda3/envs/anaconda3_11+ --no-capture-output python ~/.vscode-oss/extensions/ms-python.python-2024.4.1-universal/python_files/get_output_via_markers.py ~/.vscode-oss/extensions/ms-python.python-2024.4.1-universal/python_files/printEnvVariables.py 2024-05-10 14:10:45.242 [info] shell: bash 2024-05-10 14:10:45.334 [info] Starting Jedi language server for testdir. 2024-05-10 14:40:03.948 [info] Discover tests for workspace name: undefined - uri: /home/wja/.config/VSCodium/User/settings.json 2024-05-10 14:40:05.780 [info] Discover tests for workspace name: testdir - uri: /home/wja/testdir/tmp.py ```

I did an extension bisect to pin down the Python extension as causing the problem.

I'm using Codium and I'm not sure if this issue affects Code.

VSCodium version: VSCodium 1.89.0 (4379b66f0d4dd9881ba96fa086f387725b69a24b, 2024-05-06T17:54:09.063Z) OS version: Linux x64 5.4.0-181-generic Modes:

User Settings

``` languageServer: "Jedi" terminal • activateEnvironment: false experiments • enabled: false ```

Installed Extensions |Extension Name|Extension Id|Version| |---|---|---| |Jupyter|ms-toolsai.jupyter|2023.9.100| |Jupyter Notebook Renderers|ms-toolsai.jupyter-renderers|1.0.17| |Python|ms-python.python|2024.4.1|
wjandrea commented 1 month ago

Whoops, meant to file against the extension. See https://github.com/microsoft/vscode-python/issues/23410

daiyam commented 1 month ago

You should test with VSCode since they won't support it if it's from VSCodium...

wjandrea commented 1 month ago

@daiyam I'd rather not have to install VSC. I tried in a Codespace but there's no "Close window" or equivalent command. So, I'll see if people can reproduce the problem in VSCode, and if not I'll reopen this issue.