VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
24.27k stars 1.02k forks source link

Wayland icon is shown instead of VSCodium icon on KDE #1901

Open zartre opened 1 month ago

zartre commented 1 month ago

Describe the bug

The default Wayland icon is displayed on the taskbar and in the app switcher on KDE Plasma 6.

Please confirm that this problem is VSCodium-specific

Please confirm that the issue/resolution isn't already documented

To Reproduce Steps to reproduce the behavior:

  1. Open VSCodium
  2. Observe the taskbar and the app switcher (Alt + Tab)

Expected behavior

VSCodium icon is used instead of Wayland icon.

Screenshots

Screenshot_20240521_203426

Screenshot_20240521_203901

Desktop (please complete the following information):

wobushitankun commented 1 month ago

same as me. I meet this issue on windows when i build vscodium form the source. In the task bar vscodium show the default electron icon, but i download the vscodium on their website version the icon is the corrct one. Maybe there are some config not record into the doc.

daiyam commented 1 month ago

@wobushitankun Your issue is different of the current one! Are you on Linux with Wayland and Flatpak??? Do not answer in this issue.

zartre commented 1 month ago

I tried installing VSCodium through dnf and this version doesn't have this problem.

daiyam commented 1 month ago

I tried installing VSCodium through dnf and this version doesn't have this problem.

Yep! I was pretty sure that it's a Flatpak issue

noonsleeper commented 2 weeks ago

I tried installing VSCodium through dnf and this version doesn't have this problem.

Yep! I was pretty sure that it's a Flatpak issue

Indeed, is a well known problem in flatpak

I'll look to fix this, when I have some time to install a vm with KDE.

Some people mention that the problem maybe is how KDE ignores the icon= reference in the desktop file, and instead try to search for an icon that match with the name of the binary.

As reference, the icon installed by flatpak is named com.vscodium.codium and the binary codium

noonsleeper commented 2 weeks ago

Well, in the end, the problem has a relative easy fix/workaround =).

@zartre, @wobushitankun, can confirm the fix in codium-insider using this?

flatpak install https://dl.flathub.org/build-repo/111269/com.vscodium.codium-insiders.flatpakref

The build will be only available for 24hs

@daiyam this problem is present on upstream (vscode-oss) and also here, but is "mitigated" or "masked" because the icon that KDE borrows comes from codium-url-handler.desktop that contains the same icon that codium.desktop has in this particular case, since in ../resources/app/package.json is reported "desktopName": "codium-url-handler.desktop" (and this is the property that KDE use to set the icons for alt+tab window, the taskbar, the title bar, or even on window previews for the taskbar), but this has a pseudo explanation here

zartre commented 2 weeks ago

Hi @noonsleeper

Thanks for the fix. I can confirm that the icon is now showing!

noonsleeper commented 2 weeks ago

@zartre this patch was applied on flatpak's codium and flatpak's codium-insiders, in ~4 hours will be available.