Closed lex-ibm closed 3 weeks ago
I did not include the SHOULD_BUILD_TAR="${SHOULD_BUILD_TAR:-no}"
changes. I don't think those affect the current build process but given the script is not meant to be used like that I don't see the case.
I did not include the
SHOULD_BUILD_TAR="${SHOULD_BUILD_TAR:-no}"
changes. I don't think those affect the current build process but given the script is not meant to be used like that I don't see the case.
Yep, it doesn't affect the VSCodium's build process. So it's up to you.
I'll change my pipeline instead. I don't want to change how check_tags.sh
works other than adding GitHub Enterprise support.
LGTM
OH! A last thought, wouldn't GITHUB_HOST
be better than GH_HOST
?
OH! A last thought, wouldn't
GITHUB_HOST
be better thanGH_HOST
?
Can you make the change?
OH! A last thought, wouldn't
GITHUB_HOST
be better thanGH_HOST
?Can you make the change?
GH_HOST
comes from the GitHub CLI documentation.
Changing GH_HOST
to GITHUB_HOST
would mean changing the calls to gh
adding the --hostname
flag.
GH_HOST
comes from the GitHub CLI documentation.
Ah!
When I see git remote add origin "https://${GITHUB_USERNAME}:${GITHUB_TOKEN}@${GH_HOST}/${VERSIONS_REPOSITORY}.git" &> /dev/null
, GH_HOST
becomes an outlier.
Changing
GH_HOST
toGITHUB_HOST
would mean changing the calls togh
adding the--hostname
flag.
Ok. Let's go like that.
@lex-ibm Thanks
@daiyam thank you! I'll work on getting those electron binaries out.
Adds support for using this repo in a private Github Enterprise instance.