VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
24.27k stars 1.02k forks source link

Add Github Enterprise support #1926

Closed lex-ibm closed 3 weeks ago

lex-ibm commented 3 weeks ago

Adds support for using this repo in a private Github Enterprise instance.

lex-ibm commented 3 weeks ago

I did not include the SHOULD_BUILD_TAR="${SHOULD_BUILD_TAR:-no}" changes. I don't think those affect the current build process but given the script is not meant to be used like that I don't see the case.

daiyam commented 3 weeks ago

I did not include the SHOULD_BUILD_TAR="${SHOULD_BUILD_TAR:-no}" changes. I don't think those affect the current build process but given the script is not meant to be used like that I don't see the case.

Yep, it doesn't affect the VSCodium's build process. So it's up to you.

lex-ibm commented 3 weeks ago

I'll change my pipeline instead. I don't want to change how check_tags.sh works other than adding GitHub Enterprise support.

daiyam commented 3 weeks ago

LGTM

daiyam commented 3 weeks ago

OH! A last thought, wouldn't GITHUB_HOST be better than GH_HOST?

daiyam commented 3 weeks ago

OH! A last thought, wouldn't GITHUB_HOST be better than GH_HOST?

Can you make the change?

lex-ibm commented 3 weeks ago

OH! A last thought, wouldn't GITHUB_HOST be better than GH_HOST?

Can you make the change?

GH_HOST comes from the GitHub CLI documentation.

lex-ibm commented 3 weeks ago

Changing GH_HOST to GITHUB_HOST would mean changing the calls to gh adding the --hostname flag.

daiyam commented 3 weeks ago

GH_HOST comes from the GitHub CLI documentation.

Ah!

When I see git remote add origin "https://${GITHUB_USERNAME}:${GITHUB_TOKEN}@${GH_HOST}/${VERSIONS_REPOSITORY}.git" &> /dev/null, GH_HOST becomes an outlier.

Changing GH_HOST to GITHUB_HOST would mean changing the calls to gh adding the --hostname flag.

Ok. Let's go like that.

daiyam commented 3 weeks ago

@lex-ibm Thanks

lex-ibm commented 3 weeks ago

@daiyam thank you! I'll work on getting those electron binaries out.