VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.04k stars 1.07k forks source link

Inquiry: VSCodium versioning and release numbers for RPMS #1930

Open lex-ibm opened 3 months ago

lex-ibm commented 3 months ago

Sorry if this is not the appropriate channel to ask this.

I'm building RPMs of VSCodium and I've been asked to justify why the release field does not contain the release number and why the version number doesn't conform to Semantic Versioning, in other words, why 1.2.3.4-el7 and not 1.2.3-4.el7. It looks like that part is being patched in the SPEC.

daiyam commented 3 months ago

No problem ;)

I've used the following guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/

You can read the discussion about the release number here https://github.com/VSCodium/vscodium/discussions/788 or the PR https://github.com/VSCodium/vscodium/pull/1192

Basically, for 1.90.1.24165:

Initially, I did used the + which indicate a build version but it was conflicting with MSI and RPM. I switched to . since it looked fine from the guideline on Fedora. The - in semver is for pre-release which isn't the purpose of our 4th number.