search

VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.16k stars 1.08k forks source link

AutoUpdate fails to correctly detect how my vscodium was installed #2042

Open Zalnd opened 2 weeks ago

Zalnd commented 2 weeks ago

Following this answer to another issue, I think autoupdate is failing to correctly detect how my vscodium was installed: even though the version I have installed isn't the portable one, autoupdate is directing me to the ZIP download link.

It send you to the url because it can't detect how it was installed and so which installer to download and execute.

The update process doesn't support the Portable Mode, same as Visual Studio Code (cf note in https://code.visualstudio.com/docs/editor/portable).

Originally posted by @daiyam in https://github.com/VSCodium/vscodium/issues/1994#issuecomment-2304624965

daiyam commented 2 weeks ago

How was it?

Bug report requires at least:

Desktop (please complete the following information):

Zalnd commented 2 weeks ago

How was it?

Bug report requires at least:

Desktop (please complete the following information):

  • OS: [e.g. Mac OS, Ubuntu 20.04, etc]
  • Architecture: [e.g. x64, ia32, arm64]
  • Version: [e.g. 1.33.0]
  • App Manager: [e.g. Winget, Homebrew, Snap, AUR, RPM, Nix, ...]
  • Sandboxed: [e.g. no, Flatpak, Snap]

Sorry, I deleted the template and forgot to come back to it.

Desktop:

OS: Windows 11 Home 23H2 22631.4169 Architecture: x64 Version: VSCodium 1.92.2 24228 App Manager: None (installed for all users via VSCodium-x64-1.92.2.24228.msi)

daiyam commented 2 weeks ago

Can you give the path of the VSCodium.exe?

Zalnd commented 2 weeks ago

Sure.

C:\VSCodium\VSCodium.exe

daiyam commented 2 weeks ago

.msi are expected to be installed in Program Files...

Here the patch: https://github.com/VSCodium/vscodium/blob/master/patches/windows/update.patch

Zalnd commented 2 weeks ago

.msi are expected to be installed in Program Files...

Here the patch: https://github.com/VSCodium/vscodium/blob/master/patches/windows/update.patch

Well, in that case, this option should either be blocked or a warning should be given that auto-update will effectively be disabled. What do you think?

image

image