VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.66k stars 1.12k forks source link

VSCodium Wayland using Wayland icon instead of app icon #2127

Open y0nei opened 3 days ago

y0nei commented 3 days ago

Describe the bug This issue popped up just recently, not sure which update but this wasnt the case before. This doesnt happen with code-oss, package installed via pacman and AUR, both have same issue.

Please confirm that this problem is VSCodium-specific

Please confirm that the issue/resolution isn't already documented

To Reproduce Steps to reproduce the behavior:

  1. Run KDE Wayland
  2. Install vscodium
  3. Run "vscodium - Wayland"

Expected behavior App having the previous assigned icon.

Screenshots image image image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

daiyam commented 3 days ago

vscodium-bin isn't managed by us.

@crueter @Icelk Can you help?

y0nei commented 3 days ago

vscodium-bin isn't managed by us.

@crueter @Icelk Can you help?

The vscodium-git AUR package also has this issue

Icelk commented 3 days ago

That's odd. The icon doesn't seem to be changed 🤔 . Made it copy to the "normal" icon place in linux now too. @y0nei can you try the new version in the AUR?

y0nei commented 3 days ago

That's odd. The icon doesn't seem to be changed 🤔 . Made it copy to the "normal" icon place in linux now too. @y0nei can you try the new version in the AUR?

Yea now it has the correct icon lol, but why is the desktop file named codium-wayland instead of vscodium-wayland in /usr/share/applications now? I installed the vscodium-bin package that was the newly updated one.

Icelk commented 3 days ago

Lol great

Icelk commented 3 days ago

Ehrm ill investigate the naming thing tomorrow

crueter commented 3 days ago

Wayland requires icons to be in the standard XDG directory as far as I can tell, its icon spec is weird and doesn't at all follow X11's.

Not sure about the naming thing because I haven't touched the package in a while, totally forgot I was even the maintainer

Icelk commented 1 day ago

@y0nei Regarding the naming, it has been like that for at least half a year. But either way .desktop file naming is pretty arbitrary right?

y0nei commented 1 day ago

@y0nei Regarding the naming, it has been like that for at least half a year. But either way .desktop file naming is pretty arbitrary right?

Hmm that's funny, just now from that update that fixed the icon issue had the .desktop file names changed for me. Anyway, should i close this issue now or should i wait till the same fix gets pushed to the regular vscodium packages' PKGBUILD too?

crueter commented 20 hours ago

@daiyam manages those two packages, and it doesn't seem to be fixed just yet.