search

VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.23k stars 1.09k forks source link

Too big icon on start menu #471

Closed linsui closed 1 year ago

linsui commented 4 years ago

Describe the bug Too big icon on start menu.

Please confirm that this problem is VSCodium-specific

Please confirm that the issue/resolution isn't already documented

Screenshots sshot-009

Desktop (please complete the following information):

Bufkin commented 4 years ago

Same issue on Windows 10 Pro

linsui commented 4 years ago

https://github.com/VSCodium/vscodium/blob/master/src/resources/win32/code_150x150.png https://github.com/VSCodium/vscodium/blob/master/src/resources/win32/code_70x70.png These icons should be fixed.

Here is the recommended padding: https://docs.microsoft.com/en-us/windows/uwp/design/style/app-icons-and-logos#tile-padding-recommendations

@estatra Could you please help?

layday commented 4 years ago

The new icon is oversized on Mac as well.

atraest commented 4 years ago

Thanks for the reports. Here's the fix for Windows.

For the 70x70 one I couldn't do a perfect 66% padding because the image editor doesn't scale to floating points, so I got it to as close as possible at 65.719% padding.

@layday Can you specify which icon(s) please? Dock? Tab? Other?

@linsui @stripedpajamas Can you guys help me locate the problematic icons for Mac? I don't use neither Windows nor Mac. I recommend we solve this before merging, so I can append the Mac fix to the PR.

Can you guys confirm the location please? Mac: /vscodium/src/resources/darwin/code.icns Linux: /vscodium/src/resources/linux/code.png

In case this is correct, are there any other directories I should work on?

layday commented 4 years ago

It appears to be the case that it is slightly oversized in the dock as well as in the Finder and the tab switcher in comparison to other icons.

Screenshot 2020-08-16 at 00 15 49
atraest commented 4 years ago

Thanks for the quick reply layday. Seems to be a padding issue also. I'll wait for linsui and stripedpajamas help. I'll check the Linux one as well, looks OK on GNOME but it could use better padding too.

linsui commented 4 years ago

I don't use mac. The icons looks perfectly on Windows. Thanks! @estatra

atraest commented 4 years ago

I don't use mac. The icons looks perfectly on Windows. Thanks! @estatra

No problem!

I'll wait for stripedpajamas when he have the time to help and I'll fix the Mac icons. I'll do some padding for the Linux ones also for good measure, to make it even across all systems.

sefsh commented 4 years ago

VS Code is having the same issue and have also had that in past rebrandings.

atraest commented 4 years ago

VS Code is having the same issue and have also had that in past rebrandings.

Oh thanks for that info @yusf. Good know, I was unaware of that. I blindly followed VS Code's hierarchy and icon sizes.

For VSCodium, one PR is up and done. The Windows one is fixed. Currently working on a second PR to fix the macOS one, and improve the Linux one a little bit.

stripedpajamas commented 4 years ago

Mac: /vscodium/src/resources/darwin/code.icns

Correct @estatra

atraest commented 4 years ago

Mac: /vscodium/src/resources/darwin/code.icns

Correct @estatra

Cool. I'll work on it soon and submit a PR.

sefsh commented 4 years ago

For macOS you may want to make it adhere to the Big Sur icon guidelines. Otherwise you’ll be having similar issues within a few months.

atraest commented 4 years ago

For macOS you may want to make it adhere to the Big Sur icon guidelines. Otherwise you’ll be having similar issues within a few months.

Thanks for the heads up.

atraest commented 4 years ago

@stripedpajamas Done! The PR is ready for review.

layday commented 4 years ago

Perhaps someone on Big Sur can try it out but on Mojave it still looks too big.

atraest commented 4 years ago

Perhaps someone on Big Sur can try it out but on Mojave it still looks too big.

Hello @layday thanks for the feedback. It should be fixed now, can you please check again after the new commit?

I'm strictly following: https://developer.apple.com/design/resources/ https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/ https://developer.apple.com/design/human-interface-guidelines/macos/overview/whats-new-in-macos/

layday commented 4 years ago

It is the correct size now comparing it to the Photoshop template from your first link. Minor perhaps, but you will notice that the corners don't line up with the template's exactly. This is because the Apple shape is not a rounded rectangle but a squircle - you will notice it begins to taper inward close to the centre.

Screenshot 2020-08-23 at 02 17 45
atraest commented 4 years ago

It is the correct size now comparing it to the Photoshop template from your first link.

Good. That was the main problem I wanted to solve right now. P.S.: I use the Sketch files.

Minor perhaps, but you will notice that the corners don't line up with the template's exactly.

I know. I simply do not have the time to patch such minor details right now. I wanted to solve the major problem which was the padding issue.

This is because the Apple shape is not a rounded rectangle but a squircle - you will notice it begins to taper inward close to the centre.

The technical term is Lamé's special quartic. You don't need to teach a designer about geometry math ; ) Don't worry, it's not a lack of knowledge, it's a lack of time.

Maybe I'll give the macOS icon more time to do Apple's specific Lamé's math in the future, can't right now, sorry. As the main issue is solved I'm satisfied.

Anyone is free to submit a patch for Apple's specific Lamé's math. I doing this between snacks and study, I need to get back to work (day job) soon.

--

There is also some autogenerated mistakes (I'm guessing from the CI process?) for the icons on the Windows side of things, if anyone wants to dive into that and have the free time to do so, please go ahead. I did what I could/had the time to.

layday commented 4 years ago

Yes, well, I don't know what your credentials are - I did not mean to offend. And we all do things pro bono in our free time we might take an interest in - just like our time is precious to all of us - we only have a limited supply of it after all.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!

github-actions[bot] commented 1 year ago

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue, please open a new issue.

github-actions[bot] commented 1 year ago

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue, please open a new issue.