search

VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.15k stars 1.08k forks source link

1.49.0 doesn't launch on macOS 10.15.6 #498

Closed codeshake closed 4 years ago

codeshake commented 4 years ago

After update app icon just jump in Dock and closing immediately.

macOS 10.15.6 MacBook Pro 16"

afturner commented 4 years ago

Seeing the same thing on macOS 10.15.6, MBP 2017 + Hackintosh.

losanni commented 4 years ago

Same issue MacBook Pro (13-inch 2019) 8 GB ram

vsapountzis commented 4 years ago

Same here, MBP (16-inch 2019), macOS 10.15.6

vsivsi commented 4 years ago

As of right now, the Homebrew cask is still on 1.48.2, so running this got me back up and running after the VSCodium autoupdate caused this issue:

brew upgrade --cask vscodium

After you do this, be sure to go into Settings and set Application > Update > Mode to "manual". Or it will re-download 1.49.0 and auto-break itself again!

If that happens, or you were already at 1.48.2 in Homebrew you may need to uninstall/reinstall:

brew cask uninstall vscodium
brew cask install vscodium

All of this assumes you use Homebrew to install apps, YMMV.

KhamRRI commented 4 years ago

Same here on a 2009 MBP running 10.14.5 (dosdude1 patched). Crash report attached, I think the important lines are:

Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: EXC_I386_GPFLT

VSCodiumCrashReport.txt

NullFragment commented 4 years ago

As of right now, the Homebrew cask is still on 1.48.2

You can also go to the previous release under releases>tags and download the DMG from there: https://github.com/VSCodium/vscodium/releases/tag/1.48.2

chadlavi commented 4 years ago

Can confirm this on Big Sur beta (macOS 11.0 Beta [20A5364e])

nivekxyz commented 4 years ago

Confirmed on 2020 MacBook Pro running macOS 10.15.6

100milliongold commented 4 years ago

Confirmed on MacBook Pro (16-inch, 2019) running macOS 10.15.6

100milliongold commented 4 years ago 
brew reinstall vscodium
NetForces commented 4 years ago

Same here on macOS 10.15.6. Running code --verbose gives the following error:

{22:05}[2.5.0]~ ➭ code --verbose
[main 2020-09-11T02:05:59.553Z] Starting VS Code
[main 2020-09-11T02:05:59.560Z] from: /Applications/VSCodium.app/Contents/Resources/app
[main 2020-09-11T02:05:59.560Z] args: {
  _: [],
  diff: false,
  add: false,
  goto: false,
  'new-window': false,
  'reuse-window': false,
  wait: false,
  help: false,
  'list-extensions': false,
  'show-versions': false,
  version: false,
  verbose: true,
  status: false,
  'prof-startup': false,
  'disable-extensions': false,
  'disable-gpu': false,
  telemetry: false,
  logExtensionHostCommunication: false,
  'skip-release-notes': false,
  'disable-restore-windows': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-crash-reporter': false,
  'disable-user-env-probe': false,
  'skip-add-to-recently-opened': false,
  'unity-launch': false,
  'open-url': false,
  'file-write': false,
  'file-chmod': false,
  'driver-verbose': false,
  force: false,
  'do-not-sync': false,
  trace: false,
  'force-user-env': false,
  'open-devtools': false,
  'no-proxy-server': false,
  nolazy: false,
  'force-renderer-accessibility': false,
  'ignore-certificate-errors': false,
  'allow-insecure-localhost': false
}
[main 2020-09-11T02:05:59.565Z] Resolving machine identifier...
[main 2020-09-11T02:05:59.566Z] Resolved machine identifier: ef2d49884facbcb01c67c6cec7a5c1c63d7da081097aa4193dd21b0e0783e282
[0910/220559.586317:WARNING:process_memory_mac.cc(93)] mach_vm_read(0x7ffee5445000, 0x2000): (os/kern) invalid address (1)
[0910/220559.743525:WARNING:system_snapshot_mac.cc(42)] sysctlbyname kern.nx: No such file or directory (2)
[0910/220559.780787:WARNING:crash_report_exception_handler.cc(239)] UniversalExceptionRaise: (os/kern) failure (5)

Doing a re-install with brew reinstall vscodium works as long as you do not quit, if you do it won't restart and you will have to re-install again.

mewc commented 4 years ago

Confirmed I also experience this issue.

The above works brew reinstall vscodium, though looks like it's not the updated version. Patch is probably required.

C1ARKGABLE commented 4 years ago

The Travis Job failed while running . install_deps.sh Link

Could Travis just have crapped out? Doesn't look like install_deps.sh changed. This might be a fluke and @stripedpajamas would need a rerun the job.

stripedpajamas commented 4 years ago

Yeah, weird... job failed but we still got the release, perhaps from the previous build on master. I've deleted the assets and restarted that Mac travis job. Will see if this one goes through without timing out.

stripedpajamas commented 4 years ago

Btw thanks all for workarounds, diag info, and @C1ARKGABLE for direct link to issue 😄

stouf commented 4 years ago

I don't know if this is related but I just tried to download VSCodium for the first time using brew and got this:

» brew cask install vscodium                                                                                                                                                                                                     
Updating Homebrew...
==> Downloading https://github.com/VSCodium/vscodium/releases/download/1.49.0/VSCodium.1.49.0.dmg
Already downloaded: /Users/my-user/Library/Caches/Homebrew/downloads/86e4c9bb538e6174c71a2dd0f0210e7a3fc89b0852a3767dabd152ee759325a8--VSCodium.1.49.0.dmg
==> Verifying SHA-256 checksum for Cask 'vscodium'.
==> Note: Running `brew update` may fix SHA-256 checksum errors.
Error: Checksum for Cask 'vscodium' does not match.
Expected: 4246961123cdf526476a78979a7dcfecdcadf152d07904341eb1361215677936
  Actual: c5a242308212ae6a8ff6cc8d2e84806d49a8ff8bc82bb0554c7267f887693e87
    File: /Users/my-user/Library/Caches/Homebrew/downloads/86e4c9bb538e6174c71a2dd0f0210e7a3fc89b0852a3767dabd152ee759325a8--VSCodium.1.49.0.dmg
To retry an incomplete download, remove the file above.
If the issue persists, visit:
  https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/reporting_bugs/checksum_does_not_match_error.md

I have never downloaded VSCodium and was about to try it for the first time.

Mac OS Catalina 10.15.6 13-inch, 2018

stripedpajamas commented 4 years ago

Hi @stouf -- yeah, it's related. Working on getting the Mac binary usable again.

stouf commented 4 years ago

@stripedpajamas

Hi @stouf -- yeah, it's related. Working on getting the Mac binary usable again.

Just for your information, I just tried again and it worked! 😀 If that comes from your actions, thanks a lot! 💚 The application crashes for me too though 😅

joseluisq commented 4 years ago

After an upgrade to latest v1.49.0 on Mac 10.14.6 VSCodium simply crashes.

Process:               Electron [30241]
Path:                  /Applications/VSCodium.app/Contents/MacOS/Electron
Identifier:            com.visualstudio.code.oss
Version:               1.49.0 (1.49.0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Electron [30241]
User ID:               502

Date/Time:             2020-09-11 10:20:11.890 +0200
OS Version:            Mac OS X 10.14.6 (18G103)
Report Version:        12
deep-introspection commented 4 years ago

Same here, crashing at startup:

2020-09-11 10:37:32.948 Electron[9233:66725] ApplePersistence=NO

[0911/103733.203496:WARNING:system_snapshot_mac.cc(42)] sysctlbyname kern.nx: No such file or directory (2)

[0911/103733.214552:WARNING:crash_report_exception_handler.cc(239)] UniversalExceptionRaise: (os/kern) failure (5)

[1] 9233 segmentation fault /Applications/VSCodium.app/Contents/MacOS/Electron

joseluisq commented 4 years ago

And the "cool' thing is that on Mac 10.14.6 Mojave I can not downgrade to v1.48.2 via brew cask method (there is no option to do it) and the .dmg file for just doesn't work.

@stripedpajamas Can you provide a workaround?

HitLuca commented 4 years ago

Here's how to get vscodium working by downgrading to 1.48.2, assuming it was installed with brew cask:

brew cask uninstall vscodium
brew cask install https://raw.githubusercontent.com/Homebrew/homebrew-cask/4002df8f6bca93ed6eb40494995fcfa038cf99bf/Casks/vscodium.rb

Explanation:

based on this post explaining how to downgrade casks

aellwein commented 4 years ago

Unfortunately, all the mentioned workarounds above do not work for portable Codium installations (i use copied Codium.app with "codium-portable-data" folders to separate plugins installations). Does anyone has a hint what to do in this case?

joseluisq commented 4 years ago

The workaround doesn't work for me.

Maybe because is not signed?

HitLuca commented 4 years ago

@joseluisq Open finder, go to the Applications folder and right click on vscodium.app, with the option button pressed click open. The next screen will change and ask you if you want to open it. Just click open

joseluisq commented 4 years ago

@HitLuca thanks for the workaround. It works now.

joseluisq commented 4 years ago

Following the @HitLuca workaround on MacOS that worked for me which downgrades VSCodium to v1.48.2:

~> brew cask uninstall --force vscodium
~> brew cask install https://raw.githubusercontent.com/Homebrew/homebrew-cask/4002df8f6bca93ed6eb40494995fcfa038cf99bf/Casks/vscodium.rb

# ==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-# cask/4002df8f6bca93ed6eb40494995fcfa038cf99bf/Casks/vscodium.rb.
######################################################################## 100.0%
# ==> Downloading https://github.com/VSCodium/vscodium/releases/download/1.48.2/VSCodium.1.48.2.dmg
# ==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/144590939/e5629880-e752-11ea-9526-c4cab2e6d954?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJ
# ==> Verifying SHA-256 checksum for Cask 'vscodium'.
# ==> Installing Cask vscodium
# ==> Moving App 'VSCodium.app' to '/Applications/VSCodium.app'.
# ==> Linking Binary 'code' to '/usr/local/bin/code'.

Finally, go to Applications folder and right click on VSCodium.app and click on the open option then confirm the dialog to open or reopen VSCodium.app again.

axeII commented 4 years ago

Well I guess it's time to go back to vim.

eshimischi commented 4 years ago

Same here, reinstallation doesn't help :( MacOS 10.14.6, downgraded back to 1.48.2

vsapountzis commented 4 years ago

I uninstalled version 1.49 from brew and manually downloaded/installed the dmg for v1.48. Everything is back to normal now. macOS Catalina latest.

joseluisq commented 4 years ago

Update: VSCodium v1.49.0 was reverted on Homebrew Cask repo. https://github.com/Homebrew/homebrew-cask/pull/89084

~> brew cask info vscodium
# vscodium: 1.48.2 (auto_updates)
# https://github.com/VSCodium/vscodium
# /usr/local/Caskroom/vscodium/1.48.2 (122B)
# From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/vscodium.rb
# ==> Name
# VSCodium
# ==> Description
# Binary releases of VS Code without MS branding/telemetry/licensing
# ==> Artifacts
# VSCodium.app (App)
# /Applications/VSCodium.app/Contents/Resources/app/bin/code (Binary)
# ==> Analytics
# install: 1,338 (30 days), 4,024 (90 days), 14,961 (365 days)

So just try brew cask install vscodium which will fetch the stable v1.48.2.

CountZachula commented 4 years ago

Update: VSCodium v1.49.0 was reverted on Homebrew Cask repo. Homebrew/homebrew-cask#89084

~> brew cask info vscodium
# vscodium: 1.48.2 (auto_updates)
# https://github.com/VSCodium/vscodium
# /usr/local/Caskroom/vscodium/1.48.2 (122B)
# From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/vscodium.rb
# ==> Name
# VSCodium
# ==> Description
# Binary releases of VS Code without MS branding/telemetry/licensing
# ==> Artifacts
# VSCodium.app (App)
# /Applications/VSCodium.app/Contents/Resources/app/bin/code (Binary)
# ==> Analytics
# install: 1,338 (30 days), 4,024 (90 days), 14,961 (365 days)

So just try brew cask install vscodium which will fetch the stable v1.48.2.

Works, thanks.

If v1.49.0 is already installed, brew upgrade vscodium correctly fetches v1.48.2 too.

bconway commented 4 years ago

Won't v1.48.2 just auto-update back to v1.49.0 for many/most/all users? It seems like the bad version should be pulled promptly, but I still see it available as the latest release.

Edit: Yes. Unpacked 1.48.2 to test it, and before I even moved it to its final location, it had updated to 1.49 and would no longer launch.

joseluisq commented 4 years ago

The Mac updater is showing me that there is a new update but when I close and open the editor (v1.48.2) then the update (v1.49.0) gets applied making Impossible to start the editor again.

In this case, I think that updates should be applied only on demand but not automatically.

stripedpajamas commented 4 years ago

Alright, I've pulled the dmg and zip from the releases page and reverted https://github.com/VSCodium/versions/blob/master/darwin/latest.json to 1.48.2 for now.

It looks like possibly a big change that happened between 1.48.2 and 1.49.0 is MS upgraded to Electron 9, which required a Node version change (https://github.com/microsoft/vscode/commit/e4296330de2ae1ba69e8ecaacf6588f37a1bd639#diff-b404adfdca4d7e1432d963ba0ec07615)... I will see if I can figure out what needs to change on our side.

appkall commented 4 years ago

MacOS 10.14.6 (Mojave) crashes as well (Macbook Air mid-2013) on 1.49.0

Install via Homebrew.

stripedpajamas commented 4 years ago

Actually doesn't look like the electron update was in this release: https://github.com/microsoft/vscode/compare/1.49.0...1.48.2

Still trying to figure out what needs to happen to this repo for it to build a good Mac binary.

stripedpajamas commented 4 years ago

Actual diff: https://github.com/microsoft/vscode/compare/1.48.2...1.49.0 :facepalm:

NetForces commented 4 years ago

Hell of a changelog between these 2 release. What would be interesting to see is if the stock VSCode 1.49.0 launches under the same conditions.

bconway commented 4 years ago

I can confirm that copying over my .vscode* and Library/Application Support/* directories from VSCodium into the appropriate VSCode names launch without issue on VSCode 1.49.0.

losanni commented 4 years ago

I can confirm that copying over my .vscode* and Library/Application Support/* directories from VSCodium into the appropriate VSCode names launch without issue on VSCode 1.49.0.

Very interesting

chadlavi-casebook commented 4 years ago

as a library maintainer: what are you doing, vscode. Minor versions should only add functionality or fix bugs. If you're moving to a new major version of your most important dependency, the polite and correct thing to do is increment your major version.

Not that it wouldn't have still broken for all of us, but a new major version is a good clue that, hey, something may break under here because we're doing a big refactor.

Edit: and if they're not actually using semver, just doing some semver theatre with their version numbers, then that's a special kind of unfriendly behavior.

stripedpajamas commented 4 years ago

@chadlavi yeah idk why they love that "1" version number so much. many times they've pushed changes that break our builds, like updating to different yarn version, node version, etc.

semver theatre

:laughing: yes. I think they don't see themselves as having dependants, so anything goes. although I suppose it's not exactly commonplace to maintain "buildability" of a project across minor versions. would love MS to consider their builds part of vscode's "api" though :smile:

@bconway -- thanks for the extra info. when I first read this I thought you were saying that copying over VSCode's settings/app support made VSCodium run... unfortunately you weren't saying that :smile: I will try to build for Mac with no "VSCodium" changes (no product.json changes, no telemetry tweaking) and see if it runs. If so, I can incrementally enable our couple of changes and see where it stops. git-bisect with 50 min build times :disappointed:

thanks all for your patience

stripedpajamas commented 4 years ago

I will try to build for Mac with no "VSCodium" changes

Hmm... without making any pre-build edits it still doesn't run on Mac. So the issue is somewhere in installing dependencies + running microsoft's build tasks or the actual environment in which everything is running (e.g. node version, xcode command line tools version, etc).

update: running the commands we have listed in our travis.yml file locally on my own mac produces a binary that runs without issue:

  1. clone vscode, cd into it
  2. yarn --frozen-lockfile
  3. yarn postinstall
  4. yarn gulp compile-build
  5. yarn gulp compile-extensions-build
  6. yarn gulp minify-vscode
  7. yarn gulp vscode-darwin-min-ci
  8. open ../VSCode-darwin/Code\ -\ OSS.app

2 and 3 generate the same fsevents errors we get in travis so I don't think that's an issue (fsevents is optional dep in all cases). (also made sure zipping it didn't change anything, ofc it didn't)

next steps will be determining difference between my mac and travis build env; haven't had much luck figuring out what's different between 1.48.2 and 1.49.0 that brought this on.

stripedpajamas commented 4 years ago

update: I may have a lead, but currently having a lot of trouble getting Mac build to complete in <50 mins which is when Travis kills it :facepalm:

CountZachula commented 4 years ago

@stripedpajamas

Help us help you. We miss Codium ❤️. Maybe you can enable the Wiki and keep a living record of what you're doing? Build steps? Commit references? As this is bound to happen again, perhaps a strategy for handling this in the future after it works again, e.g. focusing on a specific stable version (rolling vs periodic updates)?

stripedpajamas commented 4 years ago

@CountZachula for sure, I'll put my steps in the wiki, good idea :+1:

the lead i mentioned yesterday was: it looks like MS is building on mac 10.15, whereas our Travis build is running an older version -- 10.13. i want to see if that makes a difference (since xcode version is affected by that), but for some reason 10.15 on Travis is slow. considering the steps I listed above ^, it usually can't complete step 6 yarn gulp minify-vscode before Travis kills the job.

so currently trying to think of ways to speed it up.

in regard to helping... if anyone can make Travis follow the steps outlined above and then upload that to a GitHub release let me know :smile: it is supposed to be very simple, there aren't a lot of knobs to turn here.

stripedpajamas commented 4 years ago

update: I did finally manage to get a single Mac build to complete with 10.15, but it is still unrunnable -- dies before the UI shows up just as before.

so back to looking for differences between Travis environment and my own Mac (as a reminder, vscode builds on my mac using the steps in our build.sh file).

DaveHarrisVA commented 4 years ago

I went looking into what exactly Travis is, and I found an alternative service that does the same thing by Microsoft, that they offer for free on pretty generous terms to open source projects. If you need another CI environment to test it out that maybe runs faster on 10.15, we may be able to use it. Microsoft Azure Pipelines

stripedpajamas commented 4 years ago

Yeah we are using azure pipelines for our windows builds, and MS is using it for all their builds. Might make sense to switch.