VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.45k stars 1.1k forks source link

Git extension is super slow since version 1.56.0 #718

Closed mlbiche closed 1 year ago

mlbiche commented 3 years ago

Describe the bug

Since VSCodium updated to 1.56.0, I am suffering important slowdown of the editor. The SCM is particularly slow in all its features (especially showing diffs and refreshing changes, but also committing). It also causes slowdown for the GitLens extension but the slowdown remain even when disabling the extension. I have run an extension audit and it has shown that Git extension was some time not responsive. It causes slowdown in the whole application, with a kind of side effect on other extensions such as ESLint or Prettier.

I have downgraded VSCodium to the version 1.55.2 and everything is running smoothly then. Upgrading back to 1.56 show the slowdown again?

Please confirm that this problem is VSCodium-specific

Please confirm that the issue/resolution isn't already documented

To Reproduce Steps to reproduce the behavior:

  1. Open a project with a remote
  2. Write down some edits.
  3. Open the SCM tab. It should be loading for while
  4. Click a changed file, the diff should takes a while to show up.

Expected behavior A SCM as fas as it as in the version 1.55.2.

Screenshots

Desktop (please complete the following information):

paulcarroty commented 3 years ago

Can't reproduce it on Linux.

Doable149 commented 3 years ago

Same problem on my MacBook Pro 2019, there are errors in the console when i try to add a file to my index :

mainThreadExtensionService.ts:62 TypeError: Cannot read property 'document' of undefined
    at /Users/owen/.vscode-oss/extensions/arjun.swagger-viewer-3.0.1/out/preview/client.js:167
    at fire (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57)
    at i.$acceptModelChanged (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
    at l._doInvokeHandler (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:91)
    at l._invokeHandler (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:91)
    at l._receiveRequest (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:91)
    at l._receiveOneMessage (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:91)
    at /Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:91
    at fire (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57)
    at S.fire (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65)
    at /Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:106
    at fire (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57)
    at S.fire (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65)
    at t._receiveMessage (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65)
    at /Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65
    at fire (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57)
    at acceptChunk (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65)
    at /Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65
    at Socket.v (/Applications/VSCodium.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:106)
    at Socket.emit (events.js:315)
    at addChunk (internal/streams/readable.js:309)
    at readableAddChunk (internal/streams/readable.js:284)
    at Socket.Readable.push (internal/streams/readable.js:223)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:62
_doInvokeHandler @ rpcProtocol.ts:417
_invokeHandler @ rpcProtocol.ts:402
_receiveRequest @ rpcProtocol.ts:318
_receiveOneMessage @ rpcProtocol.ts:245
(anonymous) @ rpcProtocol.ts:110
fire @ event.ts:622
fire @ ipc.net.ts:468
_receiveMessage @ ipc.net.ts:821
(anonymous) @ ipc.net.ts:660
fire @ event.ts:622
acceptChunk @ ipc.net.ts:241
(anonymous) @ ipc.net.ts:202
_ @ ipc.net.ts:50
emit @ events.js:315
addChunk @ internal/streams/readable.js:309
readableAddChunk @ internal/streams/readable.js:284
Readable.push @ internal/streams/readable.js:223
onStreamRead @ internal/stream_base_commons.js:188

and

[[object Object]]Cannot read property 'document' of undefined
$onExtensionRuntimeError @ mainThreadExtensionService.ts:61
_doInvokeHandler @ rpcProtocol.ts:417
_invokeHandler @ rpcProtocol.ts:402
_receiveRequest @ rpcProtocol.ts:318
_receiveOneMessage @ rpcProtocol.ts:245
(anonymous) @ rpcProtocol.ts:110
fire @ event.ts:622
fire @ ipc.net.ts:468
_receiveMessage @ ipc.net.ts:821
(anonymous) @ ipc.net.ts:660
fire @ event.ts:622
acceptChunk @ ipc.net.ts:241
(anonymous) @ ipc.net.ts:202
_ @ ipc.net.ts:50
emit @ events.js:315
addChunk @ internal/streams/readable.js:309
readableAddChunk @ internal/streams/readable.js:284
Readable.push @ internal/streams/readable.js:223
onStreamRead @ internal/stream_base_commons.js:188
daiyam commented 3 years ago

I've done a quick check of the source code of the extension. It might be an issue with the extension. At line 146-147, there is a check if there is an active editor. Then at line 194, there is no checks. This might not be the issue but the error log seems to match.

Doable149 commented 3 years ago

@daiyam If it is the extension that does this problem do we have the same problem on Visual Studio Code and not only Vscodium ?

daiyam commented 3 years ago

@Nopraz Good question. Can you check if you are getting the errors on VSCode even if it's not slow?

Doable149 commented 3 years ago

Just checked, no errors on visual studio code

mlbiche commented 3 years ago

I have also checked on VSCode the other day and have not seen any slowdown.

daiyam commented 3 years ago

I can't reproduce the error with VSCodium v1.56.1 and the examples from the OpenAPI Specification. Can you give me example of the files on which you are getting the errors? Or try those examples?

robinloeffel commented 3 years ago

It's slowed down everywhere—even when just opening up a tiny project I'll see "Initializing JS/TS language features..." and "Activating language features..." spinning in my status bar for what feels like 5 seconds each. It's gotten significantly better for me with v1.56.2, but it's still not where v1.55.2 was. I notice it most when Git pulling (via the UI) and when the autofix feature enabled via editor.codeActionsOnSave.source.fixAll is working.

MrOggy85 commented 3 years ago

I have the same issue: MacBook Pro MacOs Big Sur, 11.3

$ uname -a
Darwin (HOSTNAME) 20.4.0 Darwin Kernel Version 20.4.0: Fri Mar  5 01:14:14 PST 2021; root:xnu-7195.101.1~3/RELEASE_X86_64 x86_64

Not sure if it's related but here is also my git version:

$ git --version
git version 2.29.0

I just downloaded and installed 1.55.2 and the issue is gone

sagolubev commented 3 years ago

I faced the same issue: Mb Pro 2018, Big Sur 11.3.1 $ uname -a Darwin (HOSTNAME) 20.4.0 Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64 x86_64 Git: $ git --version git version 2.31.1

daiyam commented 3 years ago

@mlbiche @MrOggy85 @sagolubev Can you troubleshoot your setup? I'm on macOS and I can't reproduce the issue. I've opened the vscode project with gitlens activated and I don't have any slow down. Can you try a blank VSCodium with just gitlens activated?

Does the solution of @robinloeffel is working?

{
  "editor.codeActionsOnSave": {
    "source.fixAll": true
  }
}
MrOggy85 commented 3 years ago

@daiyam I tried it, but no difference. I have Gitlens extension installed but I also tried to disabled it but no difference. I also disabled all extensions, but no difference. I also removed all my settings, but no difference.

It happens for any type of files. I have tried with .ts, .json, .md It happens both if I open a folder and if I use workspace (which is even slower).

daiyam commented 3 years ago

Can you edit /Applications/VSCodium.app/Contents/Resources/app/product.json and replace "extensionAllowedProposedApi": [...], with the following code?

"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.remotehub", "ms-vscode.remotehub-insiders", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vscode.test-adapter-converter", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],
MrOggy85 commented 3 years ago

I tried it, but still no difference

MrOggy85 commented 3 years ago

I also tried removing the app and install the latest version from the .dmg file from "Releases" page here on Github. But, still same issue.

Originally I installed vscodium from brew, if that helps at all.

daiyam commented 3 years ago

I've looked at the git extension and I've seen that vscode's team have added virtual workspaces. So the change of extensionAllowedProposedApi was related to that. Maybe it's another property of product.json that needs to be updated, but I don't know...

d11-acummins commented 3 years ago

This still occurs on latest. Also tried disabling all extensions, but no luck

MrAlexWeber commented 3 years ago

I was able to confirm that downgrading to 1.55.2 fixed my issue with laggy editor behavior when switching tabs or opening files.

daiyam commented 3 years ago

Was it from local files or remote files?

stripedpajamas commented 3 years ago

I was also able to reproduce this issue on my mac with versions >1.55.2. The whole editor became noticibly sluggish. I'll keep poking at it to see if I can figure out what changed.

daiyam commented 3 years ago

While playing with remote ssh, I found that I can't connect to my VM with VSCodium where I can with VSCode...

MrAlexWeber commented 3 years ago

For me, local files.

On Thu, Jul 1, 2021 at 15:15 Baptiste Augrain @.***> wrote:

Was it from local files or remote files?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/VSCodium/vscodium/issues/718#issuecomment-872583212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRE3IM56EOKYIWZVWUOCDTVTSIZANCNFSM44REVNNQ .

atapfedora commented 3 years ago

Same here in Manjaro, I tried to install python extension on Vscodium, but it keeps "installing" and nothing happens

enx1998 commented 3 years ago

Hi, I have the same problem with 1.57.1 version and macos 11.4 on a macbook pro 16". I add that the extension doesn't work (it doesn't recognize the git repository) until I disable and enable it again.

daiyam commented 3 years ago

@atapfedora @enx1998 If you are talking about the python extension, please open another issue. This issue is about slow git...

daiyam commented 3 years ago

For the git issue, I can't reproduce it on my macOS or my arch linux... VSCode is having the same issue (for example: https://github.com/microsoft/vscode/issues/120883)

Can you share your git --version and the Git log in View/Output?

MrAlexWeber commented 3 years ago

git --version returns git version 2.32.0.

I reverted to 1.55.x so I can't get the output log right now.

On Fri, Jul 9, 2021 at 2:40 AM Baptiste Augrain @.***> wrote:

For the git issue, I can't reproduce it on my macOS or my arch linux... VSCode is having the same issue (for example: microsoft/vscode#120883 https://github.com/microsoft/vscode/issues/120883)

Can you share your git --version and the Git log in View/Output?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/VSCodium/vscodium/issues/718#issuecomment-877057109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRE3LN54ZBYPIVF6EECHDTW27YVANCNFSM44REVNNQ .

enx1998 commented 3 years ago

@daiyam git --version return git version 2.30.1 (Apple Git-130).
In Git log I can't see anything strange, only these messages repeating for each change (I think) I made to project files:

> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
> git show --textconv :resources/assets/js/main/login.js
> git ls-files --stage -- resources/assets/js/main/login.js
> git check-ignore -v -z --stdin
> git cat-file -s 341e36b9b819ada3dcf91969960bd2fc34f2f665
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/feature/newsletter_registration_flag refs/remotes/feature/

For the extension that doesn't work, I mean the native Git extension.

enx1998 commented 3 years ago

@daiyam I can add that with version 1.57.1 a project take 23 seconds to load with all extensions, instead with 1.55.2 the same project loads in 4 seconds. In 1.57.1 I can see these messages on output window log:

[2021-07-11 00:33:14.049] [renderer1] [warning] [File Watcher (chokidar)] Watcher is not using native fsevents library and is falling back to unefficient polling.
[2021-07-11 00:33:14.244] [renderer1] [error] Cannot delete property '0' of [object String]: TypeError: Cannot delete property '0' of [object String]
    at s (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:15207)
    at o (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:14258)
    at n._handler (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:14837)
    at n._handle (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:5401)
    at n.acceptUsers (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:5305)
    at Function._handleExtensionPoint (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2938:121627)
    at Va._doHandleExtensionPoints (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2938:120746)
    at Va._startLocalExtensionHost (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2944:9392)
    at async Va._scanAndHandleExtensions (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2944:8354)
    at async Va._initialize (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2938:115281)
[2021-07-11 00:33:14.266] [renderer1] [error] Cannot read property 'length' of undefined: TypeError: Cannot read property 'length' of undefined
    at Object.D [as equalsIgnoreCase] (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:60:62319)
    at file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1811:43224
    at Array.find (<anonymous>)
    at d.getDebugger (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1811:43214)
    at file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1811:39968
    at Array.forEach (<anonymous>)
    at file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1811:39852
    at Array.forEach (<anonymous>)
    at n._handler (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1811:39832)
    at n._handle (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:5401)
    at n.acceptUsers (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1809:5305)
    at Function._handleExtensionPoint (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2938:121627)
    at Va._doHandleExtensionPoints (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2938:120746)
    at Va._startLocalExtensionHost (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2944:9392)
    at async Va._scanAndHandleExtensions (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2944:8354)
    at async Va._initialize (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2938:115281)
[2021-07-11 00:33:26.443] [renderer1] [warning] UNRESPONSIVE extension host, 'amiralizadeh9480.laravel-extra-intellisense' took 99% of 1846.49ms, saved PROFILE here: 'file:///var/folders/wp/fjgmfqm9615b4x4m8106m9sc0000gn/T/exthost-ceeb95.cpuprofile' [{"id":"amiralizadeh9480.laravel-extra-intellisense","total":1830609,"percentage":99},{"id":"bmewburn.vscode-intelephense-client","total":2571,"percentage":0},{"id":"codingyu.laravel-goto-view","total":115,"percentage":0},{"id":"ms-vscode.vscode-typescript-tslint-plugin","total":1186,"percentage":0},{"id":"neilbrayfield.php-docblocker","total":257,"percentage":0},{"id":"redhat.vscode-yaml","total":3480,"percentage":0},{"id":"self","total":6398,"percentage":0},{"id":"vscode.git","total":947,"percentage":0},{"id":"vscode.typescript-language-features","total":546,"percentage":0}]
[2021-07-11 00:33:44.755] [renderer1] [warning] UNRESPONSIVE extension host, 'redhat.vscode-yaml' took 84% of 15165.477ms, saved PROFILE here: 'file:///var/folders/wp/fjgmfqm9615b4x4m8106m9sc0000gn/T/exthost-a58d85.cpuprofile' [{"id":"bmewburn.vscode-intelephense-client","total":1095300,"percentage":7},{"id":"gc","total":11412,"percentage":0},{"id":"program","total":1156,"percentage":0},{"id":"redhat.vscode-yaml","total":12773258,"percentage":84},{"id":"self","total":2813,"percentage":0},{"id":"TabNine.tabnine-vscode","total":773579,"percentage":5},{"id":"vscode.json-language-features","total":506585,"percentage":3},{"id":"vscode.npm","total":888,"percentage":0},{"id":"vscode.php-language-features","total":133,"percentage":0}]
[2021-07-11 00:33:48.395] [renderer1] [error] Unable to write to User Settings because tabnine.experimentalAutoImports is not a registered configuration.: Error: Unable to write to User Settings because tabnine.experimentalAutoImports is not a registered configuration.
    at S.reject (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:15315)
    at S.resolveAndValidate (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:18300)
    at S.doWriteConfiguration (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:12505)
    at Object.factory (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:12281)
    at E.consume (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:68:16017)
    at file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:68:15832
    at new Promise (<anonymous>)
    at E.queue (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:68:15756)
    at S.writeConfiguration (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:12266)
    at E.writeConfigurationValue (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:41473)
    at file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:27566
    at Array.map (<anonymous>)
    at E.updateValue (file:///Applications/Developer/VSCodium.new.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2409:27554)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
[2021-07-11 00:33:49.010] [renderer1] [error] Cannot read property 'length' of undefined: TypeError: Cannot read property 'length' of undefined
    at Object.GetDefaultLevel (/Users/enx/.vscode-oss/extensions/bobmagicii.autofoldyeah-1.0.6/extension.js:287:37)
    at Object.GetLevel (/Users/enx/.vscode-oss/extensions/bobmagicii.autofoldyeah-1.0.6/extension.js:262:27)
    at Object.Fold (/Users/enx/.vscode-oss/extensions/bobmagicii.autofoldyeah-1.0.6/extension.js:96:31)
    at Timeout._onTimeout (/Users/enx/.vscode-oss/extensions/bobmagicii.autofoldyeah-1.0.6/extension.js:187:20)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)

that don't appear in 1.55.2 version and Git native extension work as expected.

daiyam commented 3 years ago

@enx1998 There were a problem with the extensions https://github.com/microsoft/vscode/issues/125989 which is been fixed in v1.58.0. It was only for VSCode not for VSCodium. PS: you've posted the console log not the View/Output/Git channel...

MrAlexWeber commented 3 years ago

My VSCodium updated to 1.57.1 so I can reproduce the issue again.

When switching between files, the git log looks like:

> git show --textconv :src/sagas/sip.ts
> git ls-files --stage -- /path/to/sip.ts
> git cat-file -s 4a863852c355f1037422e48b744c9f77ea171aad
> git show --textconv :src/sagas/app.ts
> git ls-files --stage -- /path/to/app.ts
> git cat-file -s a98f892e02de07cef382b196cb4f026d61c38c74
> git show --textconv :src/sagas/sip.ts
> git ls-files --stage -- /path/to/sip.ts
> git cat-file -s 4a863852c355f1037422e48b744c9f77ea171aad

When switching between two open editor tabs, I notice a delay of about 2s before the cursor starts moving.

I'm still seeing git version 2.32.0 and which git returns /usr/local/Homebrew/bin/git

MrAlexWeber commented 3 years ago

I just updated to 1.58.0 and the issue is still present on that version as well. Thanks for looking into this!

daiyam commented 3 years ago

@MrAlexWeber I don't see nothing unusual...

Do you activities in Help/Open Process Explorer when switching tabs? Do you have the same problem when the files aren't in a git tracked folder?

MrAlexWeber commented 3 years ago

Do you activities in Help/Open Process Explorer when switching tabs?

When switching tabs I see spikes on extensionHost and watcherService but not much besides that. Sometimes I see brief spikes of activity for electron_node eslintServer.js.

I disabled ESLint and Prettier, but was still able to reproduce the issue with the unresponsive editor. The Git extension shows "⚠️ Unresponsive".

Do you have the same problem when the files aren't in a git tracked folder?

I tried to reproduce it using some plain text files and did not see the same amount of lag. Where usually I see 2-3 seconds of lag in a folder with git enabled when switching to a file, testing in a non-git directory only showed a fraction of a second of lag.

daiyam commented 3 years ago

Hi, I found this: https://github.com/microsoft/vscode/issues/107103#issuecomment-749901444 Can you try? For VSCodium, it should be:

codesign --remove-signature "/Applications/VSCodium.app/Contents/Frameworks/VSCodium Helper (Renderer).app"

or

codesign --remove-signature "/Applications/VSCodium.app/Contents/Frameworks/*.app"

Don't forget to restart VSCodium before testing both commands. Thx

mlbiche commented 3 years ago

Just tried both, even trying to remove signatures from each app within the Frameworks folder and version 1.59 is still super laggy compared to 1.55. I even tried completely removing VSCodium and reinstalling it but it doesn't fix the issue...

From issues on VSCode repo, I read that it might be related to Electron, Node.js or MacOS kernel and not the app itself, so you guys might not be able to fix it. 😞

What is strange is that I do not have the slowness with latest VSCode version...

mp3foley commented 3 years ago

I find this is most noticeable with the vscodevim extension. It makes keystrokes lag for the first few seconds after switching tabs. I have purposefully been running 1.55 for many months because of this. Today I upgraded to 1.59.1 using brew. This is still an issue.

I tested on a folder that was not a git repository and did not notice the same lag. I also tested by disabling the git extension with: "git.enabled": false, and that also helped. I will run without the git extension for now, as I mostly use other Git tools, but this will not be a solution for most users, and I am considering switching back to normal VSCode.

I am running MacOS BigSur 11.5.2, and tested with VSCodium: Version: 1.59.1 Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa

Let me know if I can assist with any other information or testing.

senfbrot commented 3 years ago

I can confirm @mp3foley's finding. Retested with 1.59.1 (installed/updated with brew) and the git integration is still horrible slow. I'm going back to 1.55 again.

Tested on MacBook Pro 2019 with MacOS BigSur 11.4

RomainFallet commented 3 years ago

Same with version 1.60 on mac OS Big Sur 11.5.2, any news on this?

VoidAndAny commented 3 years ago

Thanks for the tip (rollback to 1.55), since my Big Sur update VSCodium was almost unusable (git)

vic-pic commented 3 years ago

Hi everyone, there is some progress to this issue?

Thanks ENx

Buzut commented 3 years ago

Hey all, I had faced the issue too a while ago and reverted to 1.55.2. Still, I wanted to give it a new try.

So I tried varying versions yesterday ranging from the latest 1.60.2 to 1.55.2 and everything up from 1.55.2 is laggy. Git and GitLens are unusable.

I tried to run VS with all extensions disabled, but no luck. Back to 1.55.2 and it works like a charm. I really hope there's a solution coming or we're all stuck with an old version.

MacBook Pro 2018 macOS 11.6 name -a: 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64

All my installs are made through homebrew if that's relevant.

AnatomicJC commented 3 years ago

Hey there,

I follow this issue since some weeks. Just to say I have the same problem aka MacOS BigSur on Macbook pro Intel, VSCodium installed with brew running fine in 1.55.2 and Git / GitLens very laggy since 1.56.

amitkot commented 3 years ago

Is there any solution or workaround to this issue? It makes VSCodium unusable for programming (switching to IntelliJ for commits).

I'm on a MacBook Pro Intel running Big Sur 11.3.1, VSCodium installed with brew, currently on version 1.61.2, with GitLens installed.

AnatomicJC commented 3 years ago

Hi, I upgraded to MacOS Monterey, gave a try to last release 1.61.2 of VSCodium, but rolled back to 1.55.2.

AnatomicJC commented 3 years ago

I installed last VSCode release, and all is running smoothly 😢

amitkot commented 3 years ago

How does one revert VSCodium to a specific version?

On Friday, October 29, 2021, AnatomicJC @.***> wrote:

I installed last VSCode release, and all is running smoothly 😢

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/VSCodium/vscodium/issues/718#issuecomment-954491632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE7VWJ2PGHC7PCLDPUOA6LUJJKMDANCNFSM44REVNNQ .

AnatomicJC commented 3 years ago

I downloaded vscodium 1.55.2 release from here: https://github.com/VSCodium/vscodium/releases/tag/1.55.2

Then in settings, I set the check update to "none"

amitkot commented 3 years ago

@AnatomicJC thanks! I have a brew-installed version and I hate to lose my settings by re-installing from a zip.

BTW, is this a mac-only issue?