search

VSEScala / Scala-Dining

Contains the Scala Dining Website Design
4 stars 5 forks source link

Fix dining list can not be adjusted #250

Closed mhvis closed 1 year ago

mhvis commented 1 year ago

This PR removes the check for is_adjustable from the DiningList clean method.

I have checked and it is safe to do so. Each form has their own check on is_adjustable when it is applicable. It should be on forms anyway instead of on the model clean method, because some forms should be able to modify the dining list after the adjustable period.

mhvis commented 1 year ago

Addition:

This PR is a response to a bug report from someone. They indicated that it's not possible to change the payment link when the dining list is more than 2 days old. That is a bug. This PR also enables changing the dish, max diners and sign up deadline after the adjustable time. That's not a problem though. It's not possible to reopen an old dining list by setting the sign up deadline in the future, because the sign up deadline can't be later than the date of the dining list.