search

VSEScala / Scala-Dining

Contains the Scala Dining Website Design
4 stars 5 forks source link

Layout change on dining info page, and truncate the payment URL #255

Closed mhvis closed 1 year ago

mhvis commented 1 year ago

This is a layout change on the dining info page. Feedback is welcome. I don't mind changing it further or keeping the old layout.

The primary reason for the change is to have the info below each other instead of to the right, on mobile. That works better on mobile.

I'm not sure about the icons. Maybe it's nicer without icons.

Fixes #243

Before: image

After: image

LenaWil commented 1 year ago

I don’t know enough about Bootstrap and the CSS classes that are used in this. I could blindly test and approve it, but I am not sure how good the quality of the review would be?

Speaking of which, I didn’t know what CSS classes to use when I was working on my own pull request either, so if people have pointers, feel free to share them.

mhvis commented 1 year ago

Quality of HTML/CSS does not matter (HTML is not code). Only thing that matters is whether it looks nice and has good UX. You can use any CSS classes you like when you're writing something. You can also go wild and write your own CSS and not use Bootstrap, I don't see any issue in that either.

mhvis commented 1 year ago

@DutcherNL bump