VSEScala / Scala-Dining

Contains the Scala Dining Website Design
4 stars 5 forks source link

Add extra check for pip-compile #263

Open LenaWil opened 1 year ago

LenaWil commented 1 year ago

And also accidentally format the YML file the wrong way… again.

Anyway it’s a draft, to look into later.

mhvis commented 1 year ago

Do you want to check if dependencies are up to date?

LenaWil commented 1 year ago

Do you want to check if dependencies are up to date?

Mostly a random idea to have an extra check to have people not edit requirement.txt manually without also updating .in files if those updates were necessary. I maybe shouldn’t have opened it but at my own fork so people don’t get spammed.

mhvis commented 1 year ago

No don't worry I was just curious and I like discussing random ideas.

LenaWil commented 1 year ago

@mhvis Which Python version is running on your server? 3.8?

mhvis commented 1 year ago

3.11. The server runs the Docker image which is compiled from the Dockerfile in the root path of this repository. You can also change the version in that file.

LenaWil commented 1 year ago

I see that backports-zoneinfo is removed in requirements.txt. It needs to stay for people that have a lower Python version than 3.10. I don't know how we can force pip-compile to leave that dependency intact. Can you add it back manually for now? https://github.com/VSEScala/Scala-Dining/pull/256#issuecomment-1549544403

I was mostly asking because of this, what's the minimum version of Python we need to support?

mhvis commented 1 year ago

I realize now that it's probably not necessary to include backports-zoneinfo. It will be installed anyway when the Python version is lower than 3.9, because it's a dependency of the Django package. So it's fine if it gets removed from requirements.txt.

But yeah we only really need to support 3.11 because that's used on the server. It will likely also work without changes in Python>=3.8 which could be nice for running it locally (I had 3.8 before locally because that was in the package repo, but now it's 3.10 because I upgraded to Ubuntu 22.04, although now I use the Docker image locally as well).