CMake-ization of the build process

VSRonin / QtXlsxWriter

.xlsx file reader and writer for Qt5

http://qtxlsx.debao.me

209 stars 73 forks source link

CMake-ization of the build process #7

Closed arcadien closed 7 years ago

arcadien commented 7 years ago

Allow build of library with CMake
Fix a QScopedPointer usage which bugs with MVC14

arcadien commented 7 years ago

There was a problem in the main CMakeLists.txt which prevent build to work with current Ubuntu : this is now fixed. We also rebased on your master before opening the pull request.

VSRonin commented 7 years ago

I'm sorry but I cannot accept the pull request as it is. The original author wanted this library to be compatible with compilers that do not support C++11 and I would not be willing to break this.

I will address the QSharedPointer problem if you can describe it (I do not have MSVC 14)

If you could submit the CMake part without the changes to the code that cause the problem I'd be happy to test it and merge it

VSRonin commented 7 years ago

Stripped out the CMake code and included in 04d3ecafe5ac7c5ba4f889a6d6a84bbf5d48949b thank you very much for your help