search

VSpaceCode / vscode-which-key

which-key like menu for Visual Studio Code
https://vspacecode.github.io/docs/whichkey
MIT License
166 stars 18 forks source link

Fix typos in focus editor group commands (#81) #82

Closed CAESIUS-TIM closed 9 months ago

CAESIUS-TIM commented 9 months ago

fix https://github.com/VSpaceCode/vscode-which-key/issues/81

MarcoIeni commented 9 months ago

I would remove the word "group" because we call them just "editor" I think.

Also, what's the difference between previous and left in this context?

CAESIUS-TIM commented 9 months ago

previous also focuses left but in a cycle, meaning it will focus the rightmost window when you're on the leftmost.

It's just too powerful and different from vim shortcut.

If there is no need to change previous and next, I still recommend to change "move" into "focus" because it's confused with "move editor to another group", like workbench.action.moveEditorToLeftGroup.

editor group commands

MarcoIeni commented 9 months ago

meaning it will focus the rightmost window when you're on the leftmost

This seems like a "feature" to me 😅 but let's wait on @stevenguh to see if he has any preference. 👍

stevenguh commented 9 months ago

These makes sense to me in a first glance. which-key uses the the vscode naming