Closed hombit closed 1 year ago
create_clean_models(nmodels) returns a two-tuple: list of parameter cubes, and list of arrays representing time, flux, flux error and passband. These light-curve arrays have shape of (4, nmodels), where 4 is index over these four components. However it looks like an implicit type casting made dtype of this array to <U32, which is 32-byte long unicode string. Probably it happens in this line when the array us being created: https://github.com/lincc-frameworks/superphot-plus/blob/a9aa7d2216e0c4affc11859f35247bb8784e386c/src/superphot_plus/data_generation/make_fake_spp_data.py#L171
create_clean_models(nmodels)
(4, nmodels)
<U32
I propose to change the interface of this function and change list of Lightcurve objects instead of these arrays
Lightcurve
create_clean_models(nmodels)returns a two-tuple: list of parameter cubes, and list of arrays representing time, flux, flux error and passband. These light-curve arrays have shape of(4, nmodels), where 4 is index over these four components. However it looks like an implicit type casting made dtype of this array to<U32, which is 32-byte long unicode string. Probably it happens in this line when the array us being created: https://github.com/lincc-frameworks/superphot-plus/blob/a9aa7d2216e0c4affc11859f35247bb8784e386c/src/superphot_plus/data_generation/make_fake_spp_data.py#L171I propose to change the interface of this function and change list of
Lightcurveobjects instead of these arrays