search

VU-Cog-Sci / nideconv

fit response shapes from signal time-courses
MIT License
12 stars 11 forks source link

Change tsplot to lineplot #11

Closed lukassnoek closed 5 years ago

lukassnoek commented 5 years ago

Changed the use of tsplot to lineplot as tsplot will be deprecated. (Gets rid of annoying warning.)

Only issue is that lineplot does not have the unit parameters; no clue whether that messes up something in multisubject analyses.

Gilles86 commented 5 years ago

Ran som quick tests. Seems to do fine.

Indeed, the unit-argument is very important. However, nideconv takes care of that under the hood: GroupResponseFitter first averages within subject before plotting: https://github.com/VU-Cog-Sci/nideconv/blob/0da9647210f9ed1a1ff9871c547f074dc43e525e/nideconv/group_analysis.py#L304

So merge.