Open marcoaqil opened 3 years ago
I see in the code that the padding is hard-coded to the value of 20. it would be great if we could avoid this kind of thing
I see in the code that the padding is hard-coded to the value of 20. it would be great if we could avoid this kind of thing
certainly. make it into an argument and set default value to 20?
The main method for doing HRF convolution uses fftconvolve for speed, and a manual padding to avoid edge effects. the method used in grid prediction does not have a padding, potentially leading to slight differences between grid and iterative fit prediction.
solution: add the same padding in grid-prediction HRF convolution.