search

VUnit / vunit

VUnit is a unit testing framework for VHDL/SystemVerilog
http://vunit.github.io/
Other
722 stars 260 forks source link

Updated common log interface. #947

Closed LarsAsplund closed 1 year ago

LarsAsplund commented 1 year ago

Update common log interface as outlined in https://github.com/OSVVM/OSVVM/issues/80

umarcor commented 1 year ago

@LarsAsplund please add a fragment to https://github.com/VUnit/vunit/tree/master/docs/news.d corresponding to this PR.

LarsAsplund commented 1 year ago

@umarcor Actually, it was already added with reference to #776. See https://github.com/VUnit/vunit/blob/master/docs/news.d/776.feature.rst

umarcor commented 1 year ago

@LarsAsplund in those cases, just copy and paste the file with a different number in the filename but exactly the same content. See, for instance, https://github.com/VUnit/vunit/commit/e24d8186a0e876328279e9d95a913d8248a829d3 and http://vunit.github.io/release_notes.html#features.

I would like to contribute an enhancement to towncrier in order to handle these cases better. Yet, for now, this is the solution.

LarsAsplund commented 1 year ago

@umarcor Will do.

LarsAsplund commented 1 year ago

@umarcor Hm, my latest push with common log updates came with its own branch/PR. Should that have generated yet another news item?

umarcor commented 1 year ago

@LarsAsplund yes. in the end, we want all the issues/PRs related to this change/item/feature to show as a single list in http://vunit.github.io/release_notes.html#features. However, if you are going to push a docs/news.d: cp 776 949 or docs/news.d: cp 947 949 only, do push that to master straightaway.