Closed abaebae closed 3 months ago
I'm not an expert in VUnits code, but this looks quite good. About the string representation, I think since fixed_pkg
already has one and it's part of the VHDL standard, it should be used.
After updating license copyright years and running black, the remaining CI errors are related to the code in this PR. Check the following format mismatch:
Got:
logger = check
log_level = pass
msg = Equality check passed - Got 1010.0101 (1.03125e1).
file_name:line_num = :0
expected:
logger = check
log_level = pass
msg = Equality check passed - Got 1010.0101 (10.3125).
file_name:line_num = :0
It seems that every simulator had a slightly different default format for the to_string(real)
implementation. The format is now explicitly set to the format string "%f"
. That should lead to a consistent output style. The format style is up for debate.
See #997.
How do you want to handle the string representation of fixed_pkg types? I used the
to_string
function from the fixed_pkg. Do you prefer theto_nibble_string
style or a merge of both styles?