Va1 / browser-sync-webpack-plugin

Easily use BrowserSync in your Webpack project.

MIT License

369 stars 40 forks source link

Index has mismatched function names #17

Closed ghost closed 8 years ago

ghost commented 8 years ago

Recent update to index.js is throwing errors. The function name was updated but the prototype references and export object were not updated to match.

ghost commented 8 years ago

https://github.com/Va1/browser-sync-webpack-plugin/blob/master/index.js#L4

lean commented 8 years ago

ReferenceError: Plugin is not defined

joshfriend commented 8 years ago

18 should fix it.

joshfriend commented 8 years ago

bec45e4 introduced the change that broke things. If you rename things in the API, you should at least bump the minor version (not just the patch version).

That way, people can use ~ in the version without getting a patch update that breaks everything.

jeffj commented 8 years ago

+1 on the "ReferenceError: Plugin is not defined" error. #18 looks like the right fix.

Va1 commented 8 years ago

Fixed with @joshfriend pull request. I did publish a fresh 1.0.3 to npm with the fix included. Sorry and thanks to everyone \o