search

Va1 / browser-sync-webpack-plugin

Easily use BrowserSync in your Webpack project.
MIT License
369 stars 40 forks source link

Webpack v4.0 introduces plugin changes #56

Closed pentatronix closed 6 years ago

pentatronix commented 6 years ago

This plugin may soon have issues, since the way the plugins are written has changed substantially:

See: Breaking changes for plugins/loaders https://github.com/webpack/webpack/releases/tag/v4.0.0-beta.0

malinbranduse commented 6 years ago

@pentatronix Thanks for the info! I will keep my fork updated and do a pull request with the updates but I doubt that they'll get merged any time soon.

Va1 commented 6 years ago

hi @pentatronix . thanks for the notice, i gonna update the plugin (or @malinushj may be faster than me) to support these breaking changes and release a new version

Va1 commented 6 years ago

@pentatronix @malinushj hi guys. with the release of webpack v4 i've reviewed the plugin code and did not find any difference between how it's written and how webpack suggests to write a plugin (Plugin API, Writing a Plugin). I have no project on Webpack 3 can painlessly migrate to check though. Have you?

malinbranduse commented 6 years ago

@Va1 @pentatronix hello! didn't manage to have a look at the new docs but I do have some projects to migrate to webpack 4. I'll do that later today and come back with a response.

malinbranduse commented 6 years ago

@Va1 @pentatronix hi guys! So Valentyn, you were right, the docs haven't been updated for v4 which is quite sad but I've managed to find the proper way to do it in this repo. Made #61 and #60. Not sure if I proceeded correctly with the branching and tagging, feel free to correct me. And let me know what you think.

As a side note, the adoption rate for the community isn't too great, in my opinion. I think they jumped the boat too fast, not updating the docs and not giving plugin developers more time to migrate... But overall I love v4! Awesome new features.

onetrev commented 6 years ago

Not sure anyone is noticing or finding this, but I've isolated that it is this plugin chucking this warning from Webpack with v4.0:

DeprecationWarning: Tapable.plugin is deprecated. Use new API on ".hooks" instead

Va1 commented 6 years ago

new release of 2.2.1 is published and it includes support for Webpack v4 while still keeping compatibility with older versions.

big thanks to @malinushj @KyKyPy3 for the code and participation