Va1 / browser-sync-webpack-plugin

Easily use BrowserSync in your Webpack project.
MIT License
369 stars 40 forks source link

Webpack 5 compatibility #83

Closed davidmpaz closed 3 years ago

davidmpaz commented 4 years ago

Hello,

First of all thanks for the work done on this plugin. This is not an issue, it is more a question about webpack 5 compatibility.

How it is planned the use of this plugin in webpack 5? Would it face some compatibility issue?

The reason behind this question is the realization of: symfony/webpack-encore#145

Best regards, David

Va1 commented 4 years ago

hi David,

sorry for delayed reply.

so far, all webpack versions were supported by me or by community supplying pull requests upon major webpack release. worth mentioning is that there was no big compatibility issues and that the webpack APIs used by this package barely change. but you never know, of course.

unless you or someone else of the community wants to check it now against webpack 5-beta, i would wait for webpack 5 release and see what happens.

regards

tarponjargon commented 3 years ago

Hi - just checking if there are plans to pursue wp5 compatibility. I had browser-sync-webpack-plugin working with the last version wp4 but can't seem to get it working with 5

Va1 commented 3 years ago

hi @tarponjargon

for the time being, support of Webpack 5 can be achieved only via community contribution.

this means, if you have a project where you've upgraded to Webpack v5 and this plugin now causes failure, i encourage you to investigate what is going wrong and submit a PR with a fix. i can help you with debugging and all administrative stuff, but, myself, i do not have a Webpack project (nor time to create/find one) to test with and patch things myself.

cheers

Va1 commented 3 years ago

so, as was outlined by @Locheed in this PR, the plugin in its current state is compatible with Webpack 5. so, to avoid warnings/errors while installing it on Webpack 5 projects, I have merged the mentioned PR and bumped the version to 2.3.0. thanks everyone for participating.