search

Va1 / browser-sync-webpack-plugin

Easily use BrowserSync in your Webpack project.
MIT License
370 stars 40 forks source link

Feature request: show complition errors via browserSync fullscreen message #90

Open dkrnl opened 3 years ago

dkrnl commented 3 years ago

Hi! Thx for browser-sync-webpack-plugin!

I got an idea: show error overlay , when webpack done compliation with errors.

Оriginal code from browsersync recipes:

// pseodo code
bundler.plugin('done', function (stats) {
    if (stats.hasErrors() || stats.hasWarnings()) {
        return browserSync.sockets.emit('fullscreen:message', {
            title: "Webpack Error:",
            body:  stripAnsi(stats.toString()),
            timeout: 100000
        });
    }
    browserSync.reload();
});

Question: can i create pull request this new feature?

Va1 commented 3 years ago

hi @dkrnl

you're very welcome :)

to your question: yes, sounds like a nice idea and you surely can implement it and submit a PR. the code of the plugin is fairly simple, so i think it won't be problematic. however, we have no tests and i, personally, have no project to test against. so, please, test thoroughly yourself and paste some screenshots of the overlay.

cheers