search

Va1 / string-replace-loader

Replace loader for Webpack
MIT License
250 stars 57 forks source link

Remove unnecessary lodash dependency #16

Closed Odrin closed 7 years ago

Odrin commented 7 years ago

You really don't need lodash for two simple functions.

Va1 commented 7 years ago

@Odrin

I am willing to be consistent in projects I make and I tend to use lodash for utility purposes everywhere, that's my convention and this project is no exception. As this package is ultimately being executed by node and not being packaged to ship to frontend, lodash dependency won't bring hardly any overhead (npm and yarn are doing some magic to not download lodash multiple times if it is present in dependency tree already and, believe me, in most cases it is already present).

P.S. this way of doing 'undefined' comparisons is kinda antipattern