search

VaanaCZ / LANVP

L.A. Noire - V Patch | A community-made open source patch for the 2011's video game L.A. Noire containing a set of fixes like an unlocked framerate or support for custom aspect ratios.
Other
350 stars 15 forks source link

Bugged cases with unlocked FPS #4

Open VaanaCZ opened 3 years ago

VaanaCZ commented 3 years ago

So far, I have received 2 reports of cases being unbeatable due to bugs caused by the FPS unlock. These are:

The Quarter Moon Murders - The chandelier does not move. The Set Up - Unable to pickup the pencil. The Golden Butterfly - Suspect gets hit by car every time.

If anybody discovers any other cases which have bugs caused by the high FPS, please report them here, so that I can try and fix it.

DeathWrench commented 3 years ago

I don't know if this is still a problem. Posting just in case though. Butterfly Brooch - Suspect gets hit by a car every time. https://www.youtube.com/watch?v=rbOSP7wb5DU

VaanaCZ commented 3 years ago

I don't know if this is still a problem. Posting just in case though. Butterfly Brooch - Suspect gets hit by a car every time. https://www.youtube.com/watch?v=rbOSP7wb5DU

This was addressed by the patch and is mentioned in the readme.

DeathWrench commented 3 years ago

Sort of unrelated. I noticed in your todo list "ASI loader to load other people's plugins." if you rename the LANVP dinput8.dll to vpatch.asi and throw it in a scripts folder, Ultimate ASI Loader will load it and perhaps others. https://github.com/ThirteenAG/Ultimate-ASI-Loader/releases image

VaanaCZ commented 3 years ago

Sort of unrelated. I noticed in your todo list "ASI loader to load other people's plugins." if you rename the LANVP dinput8.dll to vpatch.asi and throw it in a scripts folder, Ultimate ASI Loader will load it and perhaps others. https://github.com/ThirteenAG/Ultimate-ASI-Loader/releases image

Glad to hear that it works. However, this behaviour is not officially supported and may go away in a future update if it conflicts with any planned feature. Will try to keep it in mind though.

The main idea with the integrated ASI loader is to also provide some sort of API for other plugins/mods to use, so plugins can be easily developed and then carried over to other versions of the game. This is just a rough idea without any serious plans as of right now.

DeathWrench commented 3 years ago

Just to see if it would work with multiple .asi's I tested it with reshade doing the same method as above, moving everything related to reshade to the scripts folder and renaming the .dll to .asi, etc. Example: image Seems to work with no issues.

VaanaCZ commented 3 years ago

I attempted to reproduce the chandelier glitch on The Quarter Moon Murders with the 60 FPS fix, but I cannot get it to appear. I believe that the reports of it being broken are false.

Ryusennin commented 3 years ago

I was about to start this game again with your great patch, running at a variable 144 fps (Freesync). I'll take notes of any potentially broken behaviour.

VaanaCZ commented 3 years ago

I was about to start this game again with your great patch, running at a variable 144 fps (Freesync). I'll take notes of any potentially broken behaviour.

That would be amazing 👍

Afaik, the only thing that should be broken now is the notepad&pencil in the case The Set Up

Ryusennin commented 3 years ago

I just finished the Homicide Desk, and I didn't encounter any physics bug with the chandelier. My game was running around 100 fps in the Hall of Records. So far so good!

Ryusennin commented 3 years ago

I completed the game and I confirm the only game-breaking bug due to high framerate is the notepad in the Set Up case.

https://youtu.be/vcbUv3rOgD4

Also, the end credits are noticeably slower when running above 30 fps. At 144 Hz, the credits are about two times too slow. In order to compare with and without the mod, you can easily access the credits in the Extras section.

Overall, thank you very much for this great patch which makes LA Noire really enjoyable on PC!

VaanaCZ commented 3 years ago

I completed the game and I confirm the only game-breaking bug due to high framerate is the notepad in the Set Up case.

https://youtu.be/vcbUv3rOgD4

Good to know, I am already attempting a fix.

Also, the end credits are noticeably slower when running above 30 fps. At 144 Hz, the credits are about two times too slow. In order to compare with and without the mod, you can easily access the credits in the Extras section.

Thanks. Noted.

Kradziej commented 2 years ago

I play fullscreen DSR upscaled with stable 144Hz (possible thanks to 3Dmigoto wrapper) and I can confirm that I have chandelier glitch, lowering to 60Hz immediately fixes this bug

xuru-thor commented 2 years ago

During The Studio Secretary Murder case, when you arrive at the police station for the last time to interrogate the suspects, Phelps wouldn't leave the car during the cutscene, causing the game to soft lock. Enabling the framerate cap fixed this issue

Psybertr0n commented 2 years ago

I also wasn't able to move the chandelier in The Quarter Moon Murders with fps_unlock=1. My framerate is capped to 120 fps at 4K.

Some other general side effects of unlocking the framerate and capping it to 120 fps I have observed are:

  1. Phelps' animation and sounds while climbing up and down ladders, stairs and pipes are sped up. The audio especially sounds quite broken. Video link
  2. Pigeons that are supposed to fly away when you approach them take off at unrealistically high speeds. Video link
  3. While driving up or down an inclined road everything within the scene including your car and the surroundings "vibrate". It's subtle but enough to be distracting while driving around. Video link

These are minor issues that I can totally put up with for the joy of gaming at gloriously high framerates. If you can fix these and maybe also implement those things on your to-do list this patch will provide the game a great modern experience. Thank you for your work on the fps unlock.

VaanaCZ commented 2 years ago

I play fullscreen DSR upscaled with stable 144Hz (possible thanks to 3Dmigoto wrapper) and I can confirm that I have chandelier glitch, lowering to 60Hz immediately fixes this bug

I also wasn't able to move the chandelier in The Quarter Moon Murders with fps_unlock=1. My framerate is capped to 120 fps at 4K.

I tried replicating this glitch and wasn't able to do so, concluding that it isn't broken. However, I'll look in to it again.

During The Studio Secretary Murder case, when you arrive at the police station for the last time to interrogate the suspects, Phelps wouldn't leave the car during the cutscene, causing the game to soft lock. Enabling the framerate cap fixed this issue

Thank you. Noted.

  1. Phelps' animation and sounds while climbing up and down ladders, stairs and pipes are sped up. The audio especially sounds quite broken. Video link

I have never encountered that before. I will try to replicate it.

  1. Pigeons that are supposed to fly away when you approach them take off at unrealistically high speeds. Video link

I think I've seen this before, but haven't written it down as a bug. That doesn't seem like it should be too hard to fix.

  1. While driving up or down an inclined road everything within the scene including your car and the surroundings "vibrate". It's subtle but enough to be distracting while driving around. Video link

I know about this, but I currently have no idea what causes it or how to fix it. The jittering makes it seem to me like if it's a float precision issue, but I have not looked into it for long enough to say if that's the case.

If you can fix these and maybe also implement those things on your to-do list this patch will provide the game a great modern experience.

Will do my best. Exam period is over, so there's time to work on this project again ;)

Thanks for the detailed reports.

Ryusennin commented 2 years ago

About the ladder sound -- that's really odd because in those places my game runs between 90 and 140 fps and I never encountered those audio bugs.

As far as the chandelier is concerned, I'm not sure the fps lock is doing anything special because I vaguely recall that it may actually be a bug in the original code. If you can trigger an auto-save before entering the building, try quitting the game and doing the same sequence again. I personally had no issue with that sequence running at around 100 fps, so it may very well be random.

delferius commented 2 years ago

Hi there!

I have a problem too with unlocked FPS. In the case "The Set Up", it's impossible to scratch the paper with unlocked fps. image

BabaYouFar commented 2 years ago

I somehow bypassed the pencil issue without turning the fix off. So Cole puts the pencil down right after picking it up with the fix, creating a soft lock.

What I did was I clicked to pick it up a couple of times while moving my mouse left, towards the notepad at the same time. That made it work.

Can anyonene else try to see if this works? Extra info: my fps is max 60, so maybe it's more janky at higher frames.

TrentonBlackburn commented 1 year ago

@BabaYouFar I am playing on Steam Deck with V-patch, running the latest stable branch of Proton.

I just hit this point in the game, and can verify that using the touch controls (which I assume mirrors mouse functionality), did in fact work. I can't necessarily put into words what I did, but I tapped on the notepad clue, then rapidly tapped the paper when the screen changed. It then prevented the glitch from setting the pencil down, and I was able to resume shading the paper using controller input.

So for any of you reading this, try and mess with it for a minute before putting in the effort to temporarily disable V-Patch! It can be done!

5e commented 1 year ago

Also couldn't do the chandelier section in The Quarter Moon Murders with fps_unlock=1. Had to turn the patch off to complete it. Running ultrawide 3440x1440 165Hz.

Also having the paper problem above.

svetter commented 1 year ago

Just to add one more data point, I am currently playing on 3440x1440 at 100fps, chandelier did not move (or maybe very very slowly).

masterfgee commented 12 months ago

First, thx so much for this patch. Without it this game is literally unplayable :)

I can confirm the chandelier bug. It only moves a few pixels. After turning off the patch I could move it normally. I am running 1080p at 240 Hz.

julianxhokaxhiu commented 10 months ago

I can confirm both bugs mentioned in the OP here as well. Disabling the mod for both section did allow me to progress as meant.

My setup: AMD Ryzen 7 5800H, Nvidia RTX 3070, 2560x1440@144Hz, L.A. Noire v2675.1 Steam edition ( which launches the Rockstar Club launcher as well )

Thank you again for this mod, a literal game changer!

VaanaCZ commented 6 months ago

I am looking into both issues. Sadly, neither of them are easy to solve.

ChristophDreier commented 5 months ago

To add some more testing data to the Chandelier bug:

With 144fps (fps_lock=0 on a 144Hz display, X11) I found the swinging not to be working. With the patch still enabled but fps_lock=60 it swinged perfectly well.

VaanaCZ commented 3 months ago

I have figured out a way to fix the pencil bug. It will be resolved with the next release. Sadly, no ETA.

VaanaCZ commented 3 months ago

Pencil bug is now fixed with the latest release: https://github.com/VaanaCZ/LANVP/releases/tag/v2.0