search

Vaarun-C / NEAT-cars

Cars which learn to drive a track using the NEAT algorithm.
2 stars 10 forks source link

Issue #4 fixed #7

Closed Saahith1204 closed 11 months ago

Saahith1204 commented 11 months ago

Fixed the AttributeError that appear on trying to add a player car. -Added a fitness variable initialized to 0 in class Player -Appended an ID value of 0 to the player car

bunsamosa-bot[bot] commented 11 months ago

Thank you from Opening this Pull Request, @Saahith1204 ! A Maintainer will review it soon!

Vaarun-C commented 11 months ago

ok @Saahith1204 this is a working solution. I agree. But don't you think having a fitness attribute for Player object feels wrong?

Vaarun-C commented 11 months ago

If you can solve this without having a fitness attribute in Player() I can give you 20. Otherwise I can give you 5-10

Vaarun-C commented 11 months ago

just look into this @Saahith1204

Saahith1204 commented 11 months ago

I agree it didn't make sense. Will look into it

Saahith1204 commented 11 months ago

Also I request for re-assignment of this issue

Vaarun-C commented 11 months ago

Can you look into "isInstance()"? Also please check the if condition

Saahith1204 commented 11 months ago

Okay can work with isInstance().

Saahith1204 commented 11 months ago

These are all the commits that I shall be contributing. Please de-assign this issue from me. Thank you

Vaarun-C commented 11 months ago

Can you revert those 2 commits? I'll merge then @Saahith1204

Saahith1204 commented 11 months ago

Will do.

Saahith1204 commented 11 months ago

I've reverted the changes made in the previous 2 commits. The file should be in the state it was in after the first commit.

Vaarun-C commented 11 months ago

!bounty 7

bunsamosa-bot[bot] commented 11 months ago

Assigned 7 Bounty points to user @Saahith1204 !