search

Vacansee / app

Predicting campus occupancy and room availability @ RPI
https://vacansee.github.io/app
GNU General Public License v3.0
12 stars 0 forks source link

Updated building names to display full names instead on abrevs #19

Closed owenwells544 closed 1 year ago

Acumane commented 1 year ago

Currently breaks quite a bit (look at heatmap, try clicking on DCC). For one, ids can't contain spaces

As discussed in the Discord, I think it's best if the full names are toggleable via some button in the navbar.

Not necessary to change the names here. In rooms.json, every building's full name is stored under its respective meta object—we can fetch this instead. See PopUpItem.vue for an example of how we already use this

mattsweet417 commented 1 year ago

I believe this still causes loading errors when clicking on buildings because the id changes. Still looking into it.

mattsweet417 commented 1 year ago

@Acumane I believe I fixed the issue if you want to re-review