search

Vadelius / swlsimNET

Combat-Simulator for Secret World Legends
Other
10 stars 7 forks source link

Buff.UnstoppableForce.Duration does not work correctly #15

Closed Posid closed 6 years ago

Posid commented 6 years ago

The argument Buff.UnstoppableForce.Duration does not seem to work correctly.

With the following APL:

Fist.Savagery, Buff.UnstoppableForce.Active && Buff.UnstoppableForce.Duration > 4 Hammer.Seethe, Buff.UnstoppableForce.Active && Hammer.Energy < 12 && Rage < 63 Hammer.UnstoppableForce, Hammer.Energy > 8 Hammer.Demolish, Buff.UnstoppableForce.Active Hammer.Demolish, Rage > 70 || Hammer.Energy > 13 Hammer.Smash

I get the following result, Savagery should have never been used because UnstoppableForce only had a duration of 1.3 seconds at that point.

[13.5s] UnstoppableForce 0.0K E(6/15) R(83/8) [14.3s] DemolishRage 91.9K E(3/15) R(37/8) [15.3s] Smash 4.9K E(5/15) R(49/8) [15.3s] [SeedOfAggression] proc! [15.3s] [Ashes] proc! [16.3s] DemolishRage 85.5K E(3/15) R(6/8) [16.3s] [ColdSilver] proc! [17.3s] Smash 12.4K E(6/15) R(18/8) [17.3s] [ColdSilver] proc! [18.3s] Demolish 34.9K E(3/15) R(50/8) [19.3s] Smash 5.3K E(4/15) R(62/8) [19.3s] [Ashes] proc! [20.2s] Savagery 0.0K E(5/13) R(65/16)

Likewise, the following APL should have savagery never being triggered because the 10 second criteria should never be fulfilled.

Fist.Savagery, Buff.UnstoppableForce.Active && Buff.UnstoppableForce.Duration > 9 Hammer.UnstoppableForce, Hammer.Energy > 8

[0.0s] UnstoppableForce 0.0K E(11/15) R(0/0) [0.1s] Savagery 0.0K E(11/13) R(0/8)

Buff.UnstoppableForce.Active is kind of redundant, but even without it there still seems to be a weird interaction.

With the following APL it is sort of accounted for because Savagery isn't being used first, but it still seems to use savagery in other situations where it shouldn't.

Fist.Savagery, Buff.UnstoppableForce.Duration > 5 Hammer.UnstoppableForce, Hammer.Energy > 8

[0.0s] UnstoppableForce 0.0K E(11/15) R(0/0) [0.1s] Savagery 0.0K E(11/13) R(0/8)

[81.5s] UnstoppableForce 0.0K E(6/15) R(80/32) [82.4s] DemolishRage 114.8K E(4/15) R(34/32) [82.4s] [SeedOfAggression] proc! [83.4s] Demolish 11.5K E(0/15) R(66/32) [83.4s] Ashes 0.8K E(0/15) R(66/32) [84.4s] Smash 5.9K E(1/15) R(78/32) [85.4s] Smash 5.9K E(2/15) R(90/32) [86.4s] Smash 14.9K E(4/15) R(100/32) [87.3s] Savagery 0.0K E(5/13) R(100/40)

niklasgs commented 6 years ago

Buff duration checks where made using milliseconds. It is solved now.