search

Vadru93 / LevelMod

THPS3 LevelMod
Other
20 stars 2 forks source link

Shattered glass wrong color in LA #96

Closed buvk closed 1 year ago

buvk commented 3 years ago

Shattered glass in LA is the wrong color, but only when you are facing away from the fountain. Does not happen in vanilla.

LevelMod image

Console image

Vadru93 commented 3 years ago

This is a known issue with the new shatter rendering and does not only happen in LA.

DCxDemo commented 3 years ago

it's also rendered 1 sided, is there any reason for that?

Vadru93 commented 3 years ago

https://github.com/Vadru93/LevelMod/blob/852079f6f6c61bcb599e494804c01714ae1ddbce/source/Physics/Shatter.cpp#L427 It should be 2 sided since no culling is applied

DCxDemo commented 3 years ago

here's the moment it shatters, you can see 1 triangle is faced forward, the other one is faced backwards. you can eventually see some bits from the other triangle as they rotate.

Skate3_2021_02_10_11_26_52_499

Vadru93 commented 3 years ago

https://github.com/Vadru93/LevelMod/blob/852079f6f6c61bcb599e494804c01714ae1ddbce/source/Objects/Mesh.h#L238 I found the problem, I need to look into how materials are submited. Probably uncommenting the Submit_Original will fix this issue.

DCxDemo commented 3 years ago

that fixed it. what about the color inversion? i think it's original material rendering bug. did you try other material flags?