Small tweaks: gen_server spec, driver_output_term deprecation, better eunit integration, travis CI

Vagabond / erlang-syslog

Erlang port driver for interacting with syslog via syslog(3)

Other

87 stars 56 forks source link

Small tweaks: gen_server spec, driver_output_term deprecation, better eunit integration, travis CI #13

Closed istr closed 4 years ago

istr commented 11 years ago

Hello, I made some very small tweaks to make syslog compile without a deprecation warning (R16B), to make rebar eunit testing as a dependency work and to make dialyzer happy inspecting the empty function code_change. Finally I managed to make travis CI pass with a small tweak for the priv-dir location (../priv instead of priv relative to ebin). Please review and pull to upstream. Thx.

complex64 commented 10 years ago

Could somebody review and merge this please? @Vagabond perhaps?

djnym commented 7 years ago

Hi, I just got added as a contributor and noticed this PR from ages ago. Is it still valid? I'd be willing to merge if someone thinks it's worthwhile or has used it in production in some capacity and believes it works. Otherwise I might be able to test it out at some point to see. At the very least can someone rebase based on most recent master? @istr perhaps?

istr commented 4 years ago

This PR is now nearly 7yrs old, probably outdated. I am recalling it now.