search

Vagabond / erlang-syslog

Erlang port driver for interacting with syslog via syslog(3)
Other
87 stars 56 forks source link

Update port_compiler tag #33

Open slashmili opened 6 years ago

slashmili commented 6 years ago

For some reason @blt has decided today to change the tags and add v in front of all tags. removing the tag causes the new builds in our production to fail 😞

I'll also make a release to hex

slashmili commented 6 years ago

1.0.6 has been released to hex

@Vagabond could you please merge this PR to master?

blt commented 6 years ago

@slashmili FWIW I don't maintain that library any longer. @tuncer has been doing tagging work as a part of https://github.com/blt/port_compiler/issues/29 I think?

ghost commented 6 years ago

1.6.0 was the outlier, all other tags were already of the form vX.Y.Z. While creating the proper v1.6.0, I removed 1.6.0. Sorry about that. I have restored the tag, since it might have been used in more configs.

To be clear, this was done since pc (including 1.6.0) is already on hex.pm, and those using the rebar3 plugin were expected to get it from hex.pm. Therefore, the removal of the improper tag (missing prefix and not an annotated tag) was deemed low risk. Again, sorry for the hiccup and thanks for the quick notification.

If anyone's wondering why you might want to prefix tags:

ghost commented 6 years ago

@slashmili, does this resolve the issue for you?

BTW, I recommend to fetch the plugin from hex.pm, since it will get cached locally and shared between projects.

slashmili commented 6 years ago

@tuncer thanks, I already fixed erlang-syslog and used the correct version and pushed to hex.

I'm not familiar with rebar so I'll leave it to @Vagabond to use hex instead of git.

BTW thanks for your explanation your. You reasoning sound solid.