Vaggan / com.edling.sectoralarm

Add suppor for Sctor Alarm to Homey.
GNU General Public License v3.0
6 stars 4 forks source link

Additional fixes #13

Closed frodeheg closed 2 years ago

frodeheg commented 2 years ago
  1. The current code adds a flow to the app that should belong to the alarm device, this was removed
  2. The capabilityOptions of the capabilities "homealarm_state" and "locked" was setting un-setable options, these had no effect whatsoever and was removed. This is a bit unfortunate really because some of the capability options for the homealarm_state are broken in the homey api. For example are some translations bad and should be fixed and secondly the "filter" in "$flow.actions.args" should be renamed to "$filter" in order to work properly (it manages to list the doorlock as an alarm device in the action flow). I have a fix for the homey api and will post a pull request to them instead.
  3. Ensured that invalid sessions caused by blocked users are displayed properly
  4. Ensured that there will be a new login if the username/password changes and the retry count has expired
  5. Moved retry count from the api to the app for faster response time.
frodeheg commented 2 years ago

One more minor change needed, closing this to open new pull request