VagueEntertainment / leafletbomb

The core Leaflet Bomb web application.
http://leafletbomb.io
Apache License 2.0
2 stars 1 forks source link

Press Release Too Far Down #85

Closed ryanleesipes closed 6 years ago

ryanleesipes commented 6 years ago

Press releases are too far down, it does highlight the featured picture but really shuns the written content. We should adjust this.

toofardown

toofardown2

bflanagin commented 6 years ago

we'll try to split the difference between what we have now, and what I thought looked good and #50 which is what we have now.

bflanagin commented 6 years ago

Tweaked from 500px to 360px.

ryanleesipes commented 6 years ago

Looks better in the Newsroom, but still looks really far down in the editor.

in_editor

bflanagin commented 6 years ago

hmmm, Okay, I tweaked it again. I'm using a percentage value instead of a Pixel count. But Now it looks right in both the editor and the newsroom.

The variable can be found in /posts/post_Item.js "topPadding" if you want to tweak it more. We use post_Item.html and its javascript file buddy everywhere there is a post.

ryanleesipes commented 6 years ago

The newsroom looks great! I guess I think the Dashboard looks too far down now. Haha.

bflanagin commented 6 years ago

A lot of it might depend on the featured image as well. On one of my machines the difference is hardly noticeable.

We could change it so that the padding is aware of what area its in to adjust it to be exactly the same. I'll see about messing around with it today.

ryanleesipes commented 6 years ago

Thank you @bflanagin