search

VahanaOpenSource / vtol_sizing

conceptual design of vtol platforms
MIT License
13 stars 7 forks source link

Unable to obtain similar results as the tutorial example from user manual #2

Closed johnZYW closed 3 years ago

johnZYW commented 3 years ago

Hi Hydra Developers @zlovering @nenanth,

I was reading the All-electric tandem tilt-wing tutorial example and realized it has same keyword values for input, defaults.yaml files as the cases/Beta_44_275_freq case. But after i ran the case myself, the results are slight different.

In my log.yaml output file, the power_installed from Vehicle section, rotor_power_reqd, battery_power_draw and C-rating from Mission section all appear to have values of 0, while the tutorials have non-zero positive values.

I have been trying to back-track at where these values are defined, and they appear to have been initialized as 0 but not assigned values afterwards. After inserting self.p_ins = powerplant.p_ins to line 154 of march_one_step.py and * self.rotor.groups[rgid].p_req[iseg]=P_plant0.001 to line 188 of engine.py, Im getting reasonable values for power_installed and rotor_power_reqd**, but unsure if its the correct way of doing. Would be grateful if you guys can help me out. Thank you.

Regards, Yuwen

Screenshots from log0.yaml without any modification:
Screen Shot 2020-12-14 at 8 40 43 pm Screen Shot 2020-12-14 at 8 40 59 pm

Screenshots from log0.yaml after modification:
Screen Shot 2020-12-14 at 9 44 26 pm Screen Shot 2020-12-14 at 9 44 40 pm

nenanth commented 3 years ago

Seems OK at first glance. Those power numbers look about right for the weight class you're getting.

On Mon, Dec 14, 2020 at 5:48 AM johnZYW notifications@github.com wrote:

Hi Hydra Developers @ananthsridharan https://github.com/ananthsridharan @nenanth https://github.com/nenanth ,

I was reading the All-electric tandem tilt-wing tutorial example and realized it has same keyword values for input, defaults.yaml files as the cases/Beta_44_275_freq case. But after i ran the case myself, the results are slight different.

In my log.yaml output file, the power_installed from Vehicle section, rotor_power_reqd, battery_power_draw and C-rating from Mission section all appear to have values of 0, while the tutorials have non-zero positive values.

I have been trying to back-track at where these values are defined, and they appear to have been initialized as 0 but not assigned values afterwards. After inserting self.p_ins = powerplant.p_ins to line 154 of march_one_step.py and * self.rotor.groups[rgid].p_req[iseg]=P_plant0.001* to line 188 of engine.py, Im getting reasonable values for power_installed and rotor_power_reqd*, but unsure if its the correct way of doing. Would be grateful if you guys can help me out. Thank you.

Regards, Yuwen

Screnshots from log0.yaml without any modification: [image: Screen Shot 2020-12-14 at 8 40 43 pm] https://user-images.githubusercontent.com/46193536/102085313-6c966200-3e51-11eb-8adb-a058a9058fd4.png [image: Screen Shot 2020-12-14 at 8 40 59 pm] https://user-images.githubusercontent.com/46193536/102085331-71f3ac80-3e51-11eb-9b6b-80276fc90961.png

Screnshots from log0.yaml after modification: [image: Screen Shot 2020-12-14 at 9 44 26 pm] https://user-images.githubusercontent.com/46193536/102088250-a1a4b380-3e55-11eb-9a5a-b6d0c82dcd21.png [image: Screen Shot 2020-12-14 at 9 44 40 pm] https://user-images.githubusercontent.com/46193536/102088263-a701fe00-3e55-11eb-9428-fd801f555f12.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VahanaOpenSource/vtol_sizing/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX46YTNTJYC7KTLVRDDTILSUYJRDANCNFSM4U2YT2PQ .

-- Talent hits a target no one else can hit; Genius hits a target no one else can see. --Arthur Schopenhauer

johnZYW commented 3 years ago

Hi nenanth, Thanks for the reply. For c_rating, i can find a definition for it in the electric motor class, but it is not imported anywhere is the codes. Is it possible you can tell me where i could import and use this class ?

Seems OK at first glance. Those power numbers look about right for the weight class you're getting. … On Mon, Dec 14, 2020 at 5:48 AM johnZYW @.> wrote: Hi Hydra Developers @ananthsridharan https://github.com/ananthsridharan @nenanth https://github.com/nenanth , I was reading the All-electric tandem tilt-wing tutorial example and realized it has same keyword values for input, defaults.yaml files as the cases/Beta_44_275_freq case. But after i ran the case myself, the results are slight different. In my log.yaml output file, the power_installed from Vehicle section, rotor_power_reqd, battery_power_draw and C-rating from Mission section all appear to have values of 0, while the tutorials have non-zero positive values. I have been trying to back-track at where these values are defined, and they appear to have been initialized as 0 but not assigned values afterwards. After inserting self.p_ins = powerplant.p_ins* to line 154 of march_one_step.py and * self.rotor.groups[rgid].p_req[iseg]=P_plant0.001 to line 188 of engine.py, Im getting reasonable values for power_installed and rotor_power_reqd, but unsure if its the correct way of doing. Would be grateful if you guys can help me out. Thank you. Regards, Yuwen Screnshots from log0.yaml without any modification: [image: Screen Shot 2020-12-14 at 8 40 43 pm] https://user-images.githubusercontent.com/46193536/102085313-6c966200-3e51-11eb-8adb-a058a9058fd4.png [image: Screen Shot 2020-12-14 at 8 40 59 pm] https://user-images.githubusercontent.com/46193536/102085331-71f3ac80-3e51-11eb-9b6b-80276fc90961.png Screnshots from log0.yaml after modification: [image: Screen Shot 2020-12-14 at 9 44 26 pm] https://user-images.githubusercontent.com/46193536/102088250-a1a4b380-3e55-11eb-9a5a-b6d0c82dcd21.png [image: Screen Shot 2020-12-14 at 9 44 40 pm] https://user-images.githubusercontent.com/46193536/102088263-a701fe00-3e55-11eb-9428-fd801f555f12.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX46YTNTJYC7KTLVRDDTILSUYJRDANCNFSM4U2YT2PQ . -- Talent hits a target no one else can hit; Genius hits a target no one else can see. --Arthur Schopenhauer

nenanth commented 3 years ago

It’s battery c rate, defined as instantaneous power / rated energy (1/hr)

On Mon, Dec 14, 2020 at 5:44 PM johnZYW notifications@github.com wrote:

Hi nenanth, Thanks for the reply. For c_rating, i can find a definition for it in the electric motor class, but it is not imported anywhere is the codes. Is it possible you can tell me where i could import and use this class ?

Seems OK at first glance. Those power numbers look about right for the weight class you're getting. … <#m7362515783243467483> On Mon, Dec 14, 2020 at 5:48 AM johnZYW @.*> wrote: Hi Hydra Developers @ananthsridharan https://github.com/ananthsridharan https://github.com/ananthsridharan https://github.com/ananthsridharan @nenanth https://github.com/nenanth https://github.com/nenanth https://github.com/nenanth , I was reading the All-electric tandem tilt-wing tutorial example and realized it has same keyword values for input, defaults.yaml files as the cases/Beta_44_275_freq case. But after i ran the case myself, the results are slight different. In my log.yaml output file, the power_installed from Vehicle section, rotor_power_reqd, battery_power_draw and C-rating from Mission section all appear to have values of 0, while the tutorials have non-zero positive values. I have been trying to back-track at where these values are defined, and they appear to have been initialized as 0 but not assigned values afterwards. After inserting self.p_ins = powerplant.p_ins to line 154 of march_one_step.py and * self.rotor.groups[rgid].p_req[iseg]=P_plant0.001 to line 188 of engine.py, Im getting reasonable values for power_installed and rotor_power_reqd, but unsure if its the correct way of doing. Would be grateful if you guys can help me out. Thank you. Regards, Yuwen Screnshots from log0.yaml without any modification: [image: Screen Shot 2020-12-14 at 8 40 43 pm] https://user-images.githubusercontent.com/46193536/102085313-6c966200-3e51-11eb-8adb-a058a9058fd4.png [image: Screen Shot 2020-12-14 at 8 40 59 pm] https://user-images.githubusercontent.com/46193536/102085331-71f3ac80-3e51-11eb-9b6b-80276fc90961.png Screnshots from log0.yaml after modification: [image: Screen Shot 2020-12-14 at 9 44 26 pm] https://user-images.githubusercontent.com/46193536/102088250-a1a4b380-3e55-11eb-9a5a-b6d0c82dcd21.png [image: Screen Shot 2020-12-14 at 9 44 40 pm] https://user-images.githubusercontent.com/46193536/102088263-a701fe00-3e55-11eb-9428-fd801f555f12.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 https://github.com/VahanaOpenSource/vtol_sizing/issues/2>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX46YTNTJYC7KTLVRDDTILSUYJRDANCNFSM4U2YT2PQ . -- Talent hits a target no one else can hit; Genius hits a target no one else can see. --Arthur Schopenhauer

—

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VahanaOpenSource/vtol_sizing/issues/2#issuecomment-744986705, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX46YVGEIS7LIILBPSKEOLSU25PHANCNFSM4U2YT2PQ .

-- Talent hits a target no one else can hit; Genius hits a target no one else can see. --Arthur Schopenhauer

johnZYW commented 3 years ago

ok, I solved the issue, thanks a lot for the help！

It’s battery c rate, defined as instantaneous power / rated energy (1/hr) On Mon, Dec 14, 2020 at 5:44 PM johnZYW @.> wrote: Hi nenanth, Thanks for the reply. For c_rating, i can find a definition for it in the electric motor class, but it is not imported anywhere is the codes. Is it possible you can tell me where i could import and use this class ? Seems OK at first glance. Those power numbers look about right for the weight class you're getting. … <#m7362515783243467483> On Mon, Dec 14, 2020 at 5:48 AM johnZYW @.> wrote: Hi Hydra Developers @ananthsridharan https://github.com/ananthsridharan https://github.com/ananthsridharan https://github.com/ananthsridharan @nenanth https://github.com/nenanth https://github.com/nenanth https://github.com/nenanth , I was reading the All-electric tandem tilt-wing tutorial example and realized it has same keyword values for input, defaults.yaml files as the cases/Beta_44_275_freq case. But after i ran the case myself, the results are slight different. In my log.yaml output file, the power_installed from Vehicle section, rotor_power_reqd, battery_power_draw and C-rating from Mission section all appear to have values of 0, while the tutorials have non-zero positive values. I have been trying to back-track at where these values are defined, and they appear to have been initialized as 0 but not assigned values afterwards. After inserting self.p_ins = powerplant.p_ins to line 154 of march_one_step.py and self.rotor.groups[rgid].p_req[iseg]=P_plant0.001 to line 188 of engine.py, Im getting reasonable values for power_installed and rotor_power_reqd*, but unsure if its the correct way of doing. Would be grateful if you guys can help me out. Thank you. Regards, Yuwen Screnshots from log0.yaml without any modification: [image: Screen Shot 2020-12-14 at 8 40 43 pm] https://user-images.githubusercontent.com/46193536/102085313-6c966200-3e51-11eb-8adb-a058a9058fd4.png [image: Screen Shot 2020-12-14 at 8 40 59 pm] https://user-images.githubusercontent.com/46193536/102085331-71f3ac80-3e51-11eb-9b6b-80276fc90961.png Screnshots from log0.yaml after modification: [image: Screen Shot 2020-12-14 at 9 44 26 pm] https://user-images.githubusercontent.com/46193536/102088250-a1a4b380-3e55-11eb-9a5a-b6d0c82dcd21.png [image: Screen Shot 2020-12-14 at 9 44 40 pm] https://user-images.githubusercontent.com/46193536/102088263-a701fe00-3e55-11eb-9428-fd801f555f12.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 <#2>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX46YTNTJYC7KTLVRDDTILSUYJRDANCNFSM4U2YT2PQ . -- Talent hits a target no one else can hit; Genius hits a target no one else can see. --Arthur Schopenhauer — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX46YVGEIS7LIILBPSKEOLSU25PHANCNFSM4U2YT2PQ . -- Talent hits a target no one else can hit; Genius hits a target no one else can see. --Arthur Schopenhauer