search

Vahe1994 / SpQR

Apache License 2.0
515 stars 40 forks source link

Outlier mask is still permuted when returned #30

Closed luccareinehr closed 11 months ago

luccareinehr commented 11 months ago

unstructured_outlier_mask is not reversely permuted when returned from SPQRUtil.quantize(). Consequently, when comparing the outlier mask and the quantised weights, the positions of the outliers do not correspond.

Is there any reason for this? From what I saw it doesn't affect the functionality of the program whatsoever, but caused me some headaches when studying and debugging the code

luccareinehr commented 11 months ago

Never mind, just noticed the NOTE on https://github.com/Vahe1994/SpQR/blob/dffd0302741e5b8a0dea9713fcf38e1cc4f3ac8f/spqr_engine.py#L209C4-L209C4. It can get easily forgotten, still