Added automatic style check

Vahe1994 / SpQR

Apache License 2.0

515 stars 40 forks source link

Added automatic style check #35

Closed Vahe1994 closed 10 months ago

Vahe1994 commented 10 months ago

Added automatic style check with black and isort
With a permission, code was taken from hivemind and petals projects

Vahe1994 commented 10 months ago

Overall looks fine, but thereare many meaningless changes - i.e permutations of import order, what does it bring?

This is due to isort library isort is a Python library to sort imports alphabetically and automatically separated into sections and by type. . You can look here for more information why this is good idea to use.

poedator commented 10 months ago

I propose not to apply changes to the contrib files from LM-Eval harness. This is to be able to make an easy claim that we did not tinker with that testing code.

Vahe1994 commented 10 months ago

I propose not to apply changes to the contrib files from LM-Eval harness. This is to be able to make an easy claim that we did not tinker with that testing code.

Good point. Excluded LM-eval-harness folder from isort and black.