Closed MeetDOD closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
style-share | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Jun 17, 2024 7:29am |
Thank you for submitting your pull request! π We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! π
@VaibhavArora314 Done with this feature, please check and give me feedback about this feature respectively, also give approprite level 1,2,3 because worked on multiple api's and similarly in frotendπ
No prob @VaibhavArora314 π
I will make this level3 due to the extra work needed to be done to merge with the like/dislike functionality
this is a great feature but I am thinking that this can be integrated with the like functionality. the user can like the post and by default the reaction will be thumbs up. if the user hovers over the like button, other reactions will be shown if the user wants to change it. on the other hand, disliking a post will cause a thumbs down reaction.
and on the post card component, you can show the reactions on the post but user need to open the post to react to it.
@VaibhavArora314 it will be total mess and headache also the reaction api will be wasted and this approach is quite tricky to follow up. hmmm it hard level i have to change many things in front + back end ... I am DEAD π
this is a great feature but I am thinking that this can be integrated with the like functionality. the user can like the post and by default the reaction will be thumbs up. if the user hovers over the like button, other reactions will be shown if the user wants to change it. on the other hand, disliking a post will cause a thumbs down reaction. and on the post card component, you can show the reactions on the post but user need to open the post to react to it.
@VaibhavArora314 it will be total mess and headache also the reaction api will be wasted and this approach is quite tricky to follow up. hmmm it hard level i have to change many things in front + back end ... I am DEAD π
I know this will be a big headache for u, maybe you can split the work in two pr 1st for the actual functionality on the backend and post integration - level3 2nd for the post card display - level2 I can only think of this way to reward for such a headache π
if its too much work then you can leave it, I will merge the current functionality then
@VaibhavArora314 You asked for it, and now I'm on it. Let's do this! π€
But what will happen to this PR ?
But what will happen to this PR ?
I am merging this, raise an issue for combining like/dislike with reactions
π Your pull request has been successfully merged! π Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! π
Pull Request Resolves [#228 ]
Title: Added reaction to the post like linkedin in style share successfully.
Description
Related Issues
Fixes #228
Changes Made
New features: Added reaction to the post like linkedin in style share.
Screenshots:
Video:
https://github.com/VaibhavArora314/StyleShare/assets/120380073/99c0f59e-9048-4620-8930-04a571bf08c6
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.