Closed manikumarreddyu closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
style-share | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 20, 2024 6:07pm |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
hey @VaibhavArora314 check it once , and let me know any changes required.
DONT MERGE THE PR @VaibhavArora314 because i have commented in mant lines if you are okay with the changes then update me , i will make any changes needed and i will commit the code without any comments in the code base
@manikumarreddyu Excellent Bro,
New:
Old:
@manikumarreddyu Excellent Bro,
- But in codesnippet can't see code in light mode.
- Also you changed the delete button, bring the previous delete button back.
New:
Old:
- This also.
Thank you @MeetDOD
thank you for reporing errors in my code @MeetDOD
sure @VaibhavArora314 . I am working on it and make it better
- Don't use plain white for the light theme. it doesn't look good. You can use light blue instead.
- There was bg image on the home page, maybe you can use that for dark mode
- As @MeetDOD said, there are some places which are breaking when changing themes like the code section of post page
- also the overall website looks darker than the actual website in dark mode. take reference from live website and keep things similar in dark mode
hey @VaibhavArora314 @MeetDOD check the latest deployment and suggest any changes
@manikumarreddyu Great work, but
old:
new:
I think you did something wrong Read more button is not perfect now
on hover:
Hmm that's it other things are fine 👍
@manikumarreddyu Great work, but
- The edit button is circular previously but now it's changed see
old:
new:
I think you did something wrong Read more button is not perfect now
- Add tag button css, it's showing white.
on hover:
Hmm that's it other things are fine 👍
okay @MeetDOD
3. As @MeetDOD said, there are some places which are breaking when changing themes like the code section of post page
hey @MeetDOD
As @MeetDOD said, there are some places which are breaking when changing themes like the code section of post page
what you said in the above ,is it resolved or still there..
Resolved @manikumarreddyu
Resolved @manikumarreddyu
okay @MeetDOD
hey @VaibhavArora314 check it once , suggest changes i have use bg image . and i dont think so adding another light color is a good thing . with bg image , it became so beautiful it is not looking plain
DONT MERGE THIS IF YOU OKAY WITH IT , just update me , i will remove commented lines in the code make and i will push again the final code
i suggest that you break the pr into 2-3 prs where each prs has mode functionality for some pages. this will make it easier for me to review and conflicts will be easier to handle
I am raising new PR hey @VaibhavArora314 dont merge any PR before merging my PR It is my sincere request for this one time please consider my request
Pull Request
Title
Light mode/Dark mode successfully added
Description
Light mode/Dark mode successfully added
Related Issues
Fixes : #115
Changes Made
Checklist
Screenshots (if applicable)
just see the preview