VaibhavArora314 / StyleShare

A simple web based platform where users can easily create, explore, and share Tailwind CSS components and designs with fellow users.
https://style-share.vercel.app
MIT License
34 stars 54 forks source link

FEAT: Light mode/Dark mode successfully added #260

Closed manikumarreddyu closed 1 week ago

manikumarreddyu commented 1 week ago

Pull Request

Title

Light mode/Dark mode successfully added

Description

Light mode/Dark mode successfully added

Related Issues

Fixes : #115

Changes Made

  1. useTheme hook created in hooks
  2. many changes are made

Checklist

Screenshots (if applicable)

just see the preview

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 6:07pm
github-actions[bot] commented 1 week ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

manikumarreddyu commented 1 week ago

hey @VaibhavArora314 check it once , and let me know any changes required.

DONT MERGE THE PR @VaibhavArora314 because i have commented in mant lines if you are okay with the changes then update me , i will make any changes needed and i will commit the code without any comments in the code base

MeetDOD commented 1 week ago

@manikumarreddyu Excellent Bro,

  1. But in codesnippet can't see code in light mode.

image

  1. Also you changed the delete button, bring the previous delete button back.

New: image

Old: image

  1. This also.

image

image

manikumarreddyu commented 1 week ago

@manikumarreddyu Excellent Bro,

  1. But in codesnippet can't see code in light mode.

image

  1. Also you changed the delete button, bring the previous delete button back.

New: image

Old: image

  1. This also.

image

image

Thank you @MeetDOD

  1. i will correct the code for codesnippet
  2. i will make change for delete button
  3. for tages also

thank you for reporing errors in my code @MeetDOD

manikumarreddyu commented 1 week ago

sure @VaibhavArora314 . I am working on it and make it better

manikumarreddyu commented 1 week ago
  1. Don't use plain white for the light theme. it doesn't look good. You can use light blue instead.
  2. There was bg image on the home page, maybe you can use that for dark mode image
  3. As @MeetDOD said, there are some places which are breaking when changing themes like the code section of post page
  4. also the overall website looks darker than the actual website in dark mode. take reference from live website and keep things similar in dark mode
  1. can you prove me the hex code for that light blue..
  2. i will set it up
  3. all are completered as far as i know 4.okay
manikumarreddyu commented 1 week ago

hey @VaibhavArora314 @MeetDOD check the latest deployment and suggest any changes

MeetDOD commented 1 week ago

@manikumarreddyu Great work, but

  1. The edit button is circular previously but now it's changed see

old: image

new: image

I think you did something wrong Read more button is not perfect now

image

  1. Add tag button css, it's showing white.

image

on hover:

image

Hmm that's it other things are fine 👍

manikumarreddyu commented 1 week ago

@manikumarreddyu Great work, but

  1. The edit button is circular previously but now it's changed see

old: image

new: image

I think you did something wrong Read more button is not perfect now

image

  1. Add tag button css, it's showing white.

image

on hover:

image

Hmm that's it other things are fine 👍

okay @MeetDOD

manikumarreddyu commented 1 week ago

3. As @MeetDOD said, there are some places which are breaking when changing themes like the code section of post page

hey @MeetDOD

As @MeetDOD said, there are some places which are breaking when changing themes like the code section of post page

what you said in the above ,is it resolved or still there..

MeetDOD commented 1 week ago

Resolved @manikumarreddyu

manikumarreddyu commented 1 week ago

Resolved @manikumarreddyu

okay @MeetDOD

manikumarreddyu commented 1 week ago

hey @VaibhavArora314 check it once , suggest changes i have use bg image . and i dont think so adding another light color is a good thing . with bg image , it became so beautiful it is not looking plain

DONT MERGE THIS IF YOU OKAY WITH IT , just update me , i will remove commented lines in the code make and i will push again the final code

VaibhavArora314 commented 1 week ago
  1. Navbar Broken image
  2. Use bg image for whole page image
  3. Code editor button should have different background in dark mode image image
  4. Only one mode option should be in code editor image
VaibhavArora314 commented 1 week ago

i suggest that you break the pr into 2-3 prs where each prs has mode functionality for some pages. this will make it easier for me to review and conflicts will be easier to handle

manikumarreddyu commented 1 week ago

I am raising new PR hey @VaibhavArora314 dont merge any PR before merging my PR It is my sincere request for this one time please consider my request