VaibhavArora314 / StyleShare

A simple web based platform where users can easily create, explore, and share Tailwind CSS components and designs with fellow users.
https://style-share.vercel.app
MIT License
40 stars 68 forks source link

fixed the slider buttons in light mode #295

Closed manikumarreddyu closed 4 months ago

manikumarreddyu commented 4 months ago

Pull Request

Title

fixed the slider buttons in light mode

Description

fixed the slider buttons in light mode

Related Issues

Fixes: #293

Changes Made

Checklist

Screenshots (if applicable)

image

Additional Notes

thats it

Footer

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 5:10pm
github-actions[bot] commented 4 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

manikumarreddyu commented 4 months ago

hey @VaibhavArora314 please check it once

manikumarreddyu commented 4 months ago

remove package lock from root

thanks @VaibhavArora314 for seeing it...i removed it

manikumarreddyu commented 4 months ago

hey @VaibhavArora314 please check it once if merge this , i will do work on another PR because that PR is dependent on this one..

manikumarreddyu commented 4 months ago

you have removed the sliding animation from the testimonials sections also, it is not automatically changing after a few seconds

previously i have used npm library ..it it doesnot have any options to change the ui of the buttons .. in this version i have implemented slider from scratch and forget to add automatic scrolling ..thanks for reporting.. @VaibhavArora314 i will implement it and update you and moreover , in my my view it is not a level 1 issue anymore as iam implementing it manually for having every feature we want..review my code and changes once and give label as per my work. Thank you

VaibhavArora314 commented 4 months ago

you have removed the sliding animation from the testimonials sections also, it is not automatically changing after a few seconds

previously i have used npm library ..it it doesnot have any options to change the ui of the buttons .. in this version i have implemented slider from scratch and forget to add automatic scrolling ..thanks for reporting.. @VaibhavArora314 i will implement it and update you and moreover , in my my view it is not a level 1 issue anymore as iam implementing it manually for having every feature we want..review my code and changes once and give label as per my work. Thank you

yes, I will update it to level 2. go ahead and implement the animation.

manikumarreddyu commented 4 months ago

you have removed the sliding animation from the testimonials sections also, it is not automatically changing after a few seconds

previously i have used npm library ..it it doesnot have any options to change the ui of the buttons .. in this version i have implemented slider from scratch and forget to add automatic scrolling ..thanks for reporting.. @VaibhavArora314 i will implement it and update you and moreover , in my my view it is not a level 1 issue anymore as iam implementing it manually for having every feature we want..review my code and changes once and give label as per my work. Thank you

yes, I will update it to level 2. go ahead and implement the animation.

3 new things are added @VaibhavArora314

  1. animation
  2. dots
  3. when clicked on dots it goes to particular testimonial

any new features for this are always welcome .. thank you

Ultimateutkarsh11 commented 4 months ago

@manikumarreddyu kindly resolve the merge conflicts

manikumarreddyu commented 4 months ago

@manikumarreddyu kindly resolve the merge conflicts

resolved successfully

manikumarreddyu commented 4 months ago

hey @Ultimateutkarsh11 please check it once

github-actions[bot] commented 4 months ago

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀